change startSDK to start

Author: jaeopt

DemoObjCApp/AppDelegate.m

@@ -56,7 +56,7 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
 -(void)initializeOptimizelySDKAsynchronous {
     self.optimizely = [[OptimizelyManager alloc] initWithSdkKey:kOptimizelySdkKey];
 
-    [self.optimizely startSDKWithCompletion:^(NSData *data, NSError *error) {
+    [self.optimizely startWithCompletion:^(NSData *data, NSError *error) {
         if (error == nil) {
             NSLog(@"Optimizely SDK initialized successfully!");
         } else {
@@ -85,7 +85,7 @@ -(void)initializeOptimizelySDKSynchronous {
         self.optimizely = nil;
     } else {
         NSError *error;
-        BOOL status = [self.optimizely startSDKWithDatafile:datafileJSON error:&error];
+        BOOL status = [self.optimizely startWithDatafile:datafileJSON error:&error];
         if (status) {
             NSLog(@"Optimizely SDK initialized successfully!");
         } else {
@@ -136,7 +136,7 @@ -(void)initializeOptimizelySDKWithCustomization {
 #endif
     }];
 
-    [self.optimizely startSDKWithCompletion:^(NSData *data, NSError *error) {
+    [self.optimizely startWithCompletion:^(NSData *data, NSError *error) {
         if (error == nil) {
             NSLog(@"Optimizely SDK initialized successfully!");
         } else {

DemoSwiftApp/AppDelegate.swift

@@ -63,7 +63,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
     func initializeOptimizelySDKAsynchronous() {
         optimizely = OptimizelyManager(sdkKey: sdkKey)
 
-        optimizely.startSDK { result in
+        optimizely.start { result in
             switch result {
             case .failure(let error):
                 print("Optimizely SDK initiliazation failed: \(error)")
@@ -87,7 +87,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
 
         do {
             let datafileJSON = try String(contentsOfFile: localDatafilePath, encoding: .utf8)
-            try optimizely!.startSDK(datafile: datafileJSON)
+            try optimizely!.start(datafile: datafileJSON)
             print("Optimizely SDK initialized successfully!")
         } catch {
             print("Optimizely SDK initiliazation failed: \(error)")
@@ -154,7 +154,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
 
         // initialize SDK
 
-        optimizely!.startSDK { result in
+        optimizely!.start { result in
             switch result {
             case .failure(let error):
                 print("Optimizely SDK initiliazation failed: \(error)")

OptimizelySDK/Optimizely/OptimizelyManager+ObjC.swift

@@ -50,16 +50,16 @@ extension OptimizelyManager {
     }
 
     @available(swift, obsoleted: 1.0)
-    @objc(startSDKWithCompletion:)
+    @objc(startWithCompletion:)
     /// Start Optimizely SDK (Asynchronous)
     ///
     /// If an updated datafile is available in the server, it's downloaded and the SDK is configured with
     /// the updated datafile.
     ///
     /// - Parameters:
     ///   - completion: callback when initialization is completed
-    public func _objcStartSDK(completion: ((Data?, NSError?) -> Void)?) {
-        startSDK { result in
+    public func _objcStart(completion: ((Data?, NSError?) -> Void)?) {
+        start { result in
             switch result {
             case .failure(let error):
                 completion?(nil, self.convertErrorForObjc(error))
@@ -70,19 +70,19 @@ extension OptimizelyManager {
     }
 
     @available(swift, obsoleted: 1.0)
-    @objc(startSDKWithDatafile:error:)
+    @objc(startWithDatafile:error:)
     /// Start Optimizely SDK (Synchronous)
     ///
     /// - Parameters:
     ///   - datafile: This datafile will be used when cached copy is not available (fresh start).
     ///             A cached copy from previous download is used if it's available.
     ///             The datafile will be updated from the server in the background thread.
-    public func _objcStartSDKWith(datafile:String) throws {
-        try self.startSDK(datafile: datafile)
+    public func _objcStartWith(datafile:String) throws {
+        try self.start(datafile: datafile)
     }
 
     @available(swift, obsoleted: 1.0)
-    @objc(startSDKWithDatafile:doFetchDatafileBackground:error:)
+    @objc(startWithDatafile:doFetchDatafileBackground:error:)
     /// Start Optimizely SDK (Synchronous)
     ///
     /// - Parameters:
@@ -92,8 +92,8 @@ extension OptimizelyManager {
     ///   - doFetchDatafileBackground: This is for debugging purposes when
     ///             you don't want to download the datafile.  In practice, you should allow the
     ///             background thread to update the cache copy (optional)
-    public func _objcStartSDK(datafile: Data, doFetchDatafileBackground: Bool = true) throws {
-        try self.startSDK(datafile: datafile, doFetchDatafileBackground: doFetchDatafileBackground)
+    public func _objcStart(datafile: Data, doFetchDatafileBackground: Bool = true) throws {
+        try self.start(datafile: datafile, doFetchDatafileBackground: doFetchDatafileBackground)
     }
 
     @available(swift, obsoleted: 1.0)

OptimizelySDK/Optimizely/OptimizelyManager.swift

@@ -90,7 +90,7 @@ open class OptimizelyManager: NSObject {
     /// - Parameters:
     ///   - resourceTimeout: timeout for datafile download (optional)
     ///   - completion: callback when initialization is completed
-    public func startSDK(resourceTimeout:Double? = nil, completion: ((OptimizelyResult<Data>) -> Void)?=nil) {
+    public func start(resourceTimeout:Double? = nil, completion: ((OptimizelyResult<Data>) -> Void)?=nil) {
         fetchDatafileBackground(resourceTimeout:resourceTimeout) { result in
             switch result {
             case .failure:
@@ -116,12 +116,12 @@ open class OptimizelyManager: NSObject {
     ///   - datafile: This datafile will be used when cached copy is not available (fresh start).
     ///             A cached copy from previous download is used if it's available.
     ///             The datafile will be updated from the server in the background thread.
-    public func startSDK(datafile: String) throws {
+    public func start(datafile: String) throws {
         guard let datafileData = datafile.data(using: .utf8) else {
             throw OptimizelyError.dataFileInvalid
         }
 
-        try startSDK(datafile: datafileData)
+        try start(datafile: datafileData)
     }
 
     /// Start Optimizely SDK (Synchronous)
@@ -133,7 +133,7 @@ open class OptimizelyManager: NSObject {
     ///   - doFetchDatafileBackground: This is for debugging purposes when
     ///             you don't want to download the datafile.  In practice, you should allow the
     ///             background thread to update the cache copy (optional)
-    public func startSDK(datafile: Data, doFetchDatafileBackground: Bool = true) throws {
+    public func start(datafile: Data, doFetchDatafileBackground: Bool = true) throws {
         let cachedDatafile = self.datafileHandler.loadSavedDatafile(sdkKey: self.sdkKey)
 
         let selectedDatafile = cachedDatafile ?? datafile