Removes deprecated revenue value support (#95)

Author: rashidsp

lib/optimizely.rb

@@ -201,13 +201,6 @@ def track(event_key, user_id, attributes = nil, event_tags = nil)
         return nil
       end
 
-      if event_tags && event_tags.is_a?(Numeric)
-        event_tags = {
-          'revenue' => event_tags
-        }
-        @logger.log(Logger::WARN, 'Event value is deprecated in track call. Use event tags to pass in revenue value instead.')
-      end
-
       return nil unless user_inputs_valid?(attributes, event_tags)
 
       experiment_ids = @config.get_experiment_ids_for_event(event_key)

spec/project_spec.rb

@@ -406,17 +406,6 @@ class InvalidErrorHandler; end
       expect(project_instance.event_dispatcher).to have_received(:dispatch_event).with(Optimizely::Event.new(:post, conversion_log_url, params, post_headers)).once
     end
 
-    it 'should properly track an event by calling dispatch_event with right params with deprecated revenue provided' do
-      params = @expected_track_event_params
-      params[:visitors][0][:snapshots][0][:events][0].merge!(revenue: 42,
-                                                             tags: {'revenue' => 42})
-
-      allow(project_instance.event_dispatcher).to receive(:dispatch_event).with(instance_of(Optimizely::Event))
-      project_instance.track('test_event', 'test_user', nil, 42)
-      expect(project_instance.event_dispatcher).to have_received(:dispatch_event).with(Optimizely::Event.new(:post, conversion_log_url, params, post_headers)).once
-      expect(spy_logger).to have_received(:log).once.with(Logger::WARN, 'Event value is deprecated in track call. Use event tags to pass in revenue value instead.')
-    end
-
     it 'should properly track an event by calling dispatch_event with right params with attributes provided' do
       params = @expected_track_event_params
       params[:visitors][0][:attributes] = [{
@@ -474,6 +463,9 @@ class InvalidErrorHandler; end
     it 'should raise an exception when called with event tags in an invalid format' do
       expect { project_instance.track('test_event', 'test_user', nil, 'invalid_tags') }
         .to raise_error(Optimizely::InvalidEventTagFormatError)
+      expect { project_instance.track('test_event', 'test_user', nil, 42) }
+        .to raise_error(Optimizely::InvalidEventTagFormatError)
+      expect(spy_logger).to have_received(:log).twice.with(Logger::ERROR, 'Provided event tags are in an invalid format.')
     end
 
     it 'should return false when called with event tags in an invalid format' do