skip identify on user_context clone (#318)

Author: andrewleap-optimizely

lib/optimizely/optimizely_user_context.rb

@@ -26,7 +26,7 @@ class OptimizelyUserContext
 
     OptimizelyDecisionContext = Struct.new(:flag_key, :rule_key)
     OptimizelyForcedDecision = Struct.new(:variation_key)
-    def initialize(optimizely_client, user_id, user_attributes)
+    def initialize(optimizely_client, user_id, user_attributes, identify: true)
       @attr_mutex = Mutex.new
       @forced_decision_mutex = Mutex.new
       @qualified_segment_mutex = Mutex.new
@@ -36,11 +36,11 @@ def initialize(optimizely_client, user_id, user_attributes)
       @forced_decisions = {}
       @qualified_segments = nil
 
-      @optimizely_client&.identify_user(user_id: user_id)
+      @optimizely_client&.identify_user(user_id: user_id) if identify
     end
 
     def clone
-      user_context = OptimizelyUserContext.new(@optimizely_client, @user_id, user_attributes)
+      user_context = OptimizelyUserContext.new(@optimizely_client, @user_id, user_attributes, identify: false)
       @forced_decision_mutex.synchronize { user_context.instance_variable_set('@forced_decisions', @forced_decisions.dup) unless @forced_decisions.empty? }
       @qualified_segment_mutex.synchronize { user_context.instance_variable_set('@qualified_segments', @qualified_segments.dup) unless @qualified_segments.nil? }
       user_context

spec/optimizely_user_context_spec.rb

@@ -829,7 +829,7 @@
   it 'should hit other audience with segments in ab test' do
     stub_request(:post, impression_log_url)
     stub_request(:post, 'https://api.zaius.com/v3/events').to_return(status: 200)
-    user_context_obj = Optimizely::OptimizelyUserContext.new(integration_project_instance, 'tester', 'age' => 30)
+    user_context_obj = Optimizely::OptimizelyUserContext.new(integration_project_instance, 'tester', {'age' => 30})
     user_context_obj.qualified_segments = %w[odp-segment-none]
 
     decision = user_context_obj.decide('flag-segment', [Optimizely::Decide::OptimizelyDecideOption::IGNORE_USER_PROFILE_SERVICE])
@@ -894,6 +894,22 @@
     integration_project_instance.close
   end
 
+  it 'should skip identify with decisions' do
+    stub_request(:post, impression_log_url)
+    expect(integration_project_instance.odp_manager).to receive(:identify_user).with({user_id: 'tester'})
+    expect(spy_logger).not_to receive(:log).with(Logger::ERROR, anything)
+
+    user_context = Optimizely::OptimizelyUserContext.new(integration_project_instance, 'tester', {})
+
+    expect(integration_project_instance.odp_manager).not_to receive(:identify_user)
+
+    user_context.decide('flag-segment')
+    user_context.decide_all
+    user_context.decide_for_keys(['flag-segment'])
+
+    integration_project_instance.close
+  end
+
   describe '#fetch_qualified_segments' do
     it 'should fetch segments' do
       stub_request(:post, 'https://api.zaius.com/v3/graphql').to_return(status: 200, body: good_response_data.to_json)