Add tests to ensure pruning nil values

Author: mauerbac

lib/optimizely/event_builder.rb

@@ -132,7 +132,7 @@ def add_attributes(attributes)
       return if attributes.nil?
 
       attributes.keys.each do |attribute_key|
-        # Omit falsy attribute values
+        # Omit falsy or nil attribute values
         attribute_value = attributes[attribute_key]
         next unless attribute_value
 

spec/event_builder_spec.rb

@@ -125,6 +125,18 @@
     expect(conversion_event.http_verb).to eq(:post)
   end
 
+  it 'should create a valid V2 Event when create_conversion_event is called when an attribute value is nil' do
+    @expected_conversion_params['userFeatures'] = [
+    ]
+
+    attributes = {'browser_type' => nil}
+
+    conversion_event = @event_builder.create_conversion_event('test_event', 'test_user', attributes, nil, {'111127' => '111128'})
+    expect(conversion_event.params).to eq(@expected_conversion_params)
+    expect(conversion_event.url).to eq(@expected_conversion_url)
+    expect(conversion_event.http_verb).to eq(:post)
+  end
+
   it 'should create a valid V2 Event when create_conversion_event is called with revenue event tag' do
     @expected_conversion_params['eventMetrics'] = [{
       'name' => 'revenue',
@@ -147,6 +159,24 @@
     expect(conversion_event.http_verb).to eq(:post)
   end
 
+  it 'should create a valid V2 Event when create_conversion_event is called when an event tag value is nil' do
+    @expected_conversion_params['eventFeatures'] = [
+      {
+        'name' => 'purchasePrice',
+        'type' => 'custom',
+        'value' => 64.32,
+        'shouldIndex' => false
+      },
+    ]
+
+    event_tags = {'category' => nil,'purchasePrice' => 64.32}
+
+    conversion_event = @event_builder.create_conversion_event('test_event', 'test_user', nil, event_tags, {'111127' => '111128'})
+    expect(conversion_event.params).to eq(@expected_conversion_params)
+    expect(conversion_event.url).to eq(@expected_conversion_url)
+    expect(conversion_event.http_verb).to eq(:post)
+  end
+
   it 'should create a valid V2 Event when create_conversion_event is called with revenue event tag' do
     @expected_conversion_params['eventMetrics'] = []
     @expected_conversion_params['eventFeatures'] = [