fix: Lint errors after rubocop update. (#136)

Author: rashidsp

lib/optimizely/bucketer.rb

@@ -93,7 +93,10 @@ def bucket(experiment, bucketing_id, user_id)
 
       # Handle the case when the traffic range is empty due to sticky bucketing
       if variation_id == ''
-        @config.logger.log(Logger::DEBUG, 'Bucketed into an empty traffic range. Returning nil.')
+        @config.logger.log(
+          Logger::DEBUG,
+          'Bucketed into an empty traffic range. Returning nil.'
+        )
       end
 
       @config.logger.log(Logger::INFO, "User '#{user_id}' is in no variation.")

lib/optimizely/helpers/validator.rb

@@ -112,9 +112,9 @@ def inputs_valid?(variables, logger = NoOpLogger.new, level = Logger::ERROR)
           next if value.is_a?(String) && !value.empty?
 
           is_valid = false
-          if logger_valid?(logger) && level
-            logger.log(level, "#{Optimizely::Helpers::Constants::INPUT_VARIABLES[key.to_s.upcase]} is invalid")
-          end
+          next unless logger_valid?(logger) && level
+
+          logger.log(level, "#{Optimizely::Helpers::Constants::INPUT_VARIABLES[key.to_s.upcase]} is invalid")
         end
         is_valid
       end

lib/optimizely/project_config.rb

@@ -129,9 +129,9 @@ def initialize(datafile, logger, error_handler)
           variation_id = variation['id']
           variation['featureEnabled'] = variation['featureEnabled'] == true
           variation_variables = variation['variables']
-          unless variation_variables.nil?
-            @variation_id_to_variable_usage_map[variation_id] = generate_key_map(variation_variables, 'id')
-          end
+          next if variation_variables.nil?
+
+          @variation_id_to_variable_usage_map[variation_id] = generate_key_map(variation_variables, 'id')
         end
         @variation_id_map[key] = generate_key_map(variations, 'id')
         @variation_key_map[key] = generate_key_map(variations, 'key')
@@ -357,9 +357,7 @@ def set_forced_variation(experiment_key, user_id, variation_key)
         return false
       end
 
-      unless @forced_variation_map.key? user_id
-        @forced_variation_map[user_id] = {}
-      end
+      @forced_variation_map[user_id] = {} unless @forced_variation_map.key? user_id
       @forced_variation_map[user_id][experiment_id] = variation_id
       @logger.log(Logger::DEBUG, "Set variation '#{variation_id}' for experiment '#{experiment_id}' and "\
                   "user '#{user_id}' in the forced variation map.")

optimizely-sdk.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'coveralls'
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec'
-  spec.add_development_dependency 'rubocop'
+  spec.add_development_dependency 'rubocop', '~> 0.60.0'
   spec.add_development_dependency 'webmock'
 
   spec.add_runtime_dependency 'httparty', '~> 0.11'