Skip to content

Commit f3b656d

Browse files
arafay-folio3mikeproeng37
authored andcommitted
revert get enabled features sorted (#229)
1 parent 788f68f commit f3b656d

File tree

3 files changed

+24
-34
lines changed

3 files changed

+24
-34
lines changed

OptimizelySDKCore/OptimizelySDKCore/Optimizely.m

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -363,8 +363,7 @@ - (NSString *)getFeatureVariableString:(nullable NSString *)featureKey
363363
[enabledFeatures addObject:featureKey];
364364
}
365365
}
366-
NSArray *enabledFeaturesSorted = [enabledFeatures sortedArrayUsingSelector:@selector(caseInsensitiveCompare:)];
367-
return enabledFeaturesSorted;
366+
return enabledFeatures;
368367
}
369368

370369
#pragma mark trackEvent methods

OptimizelySDKCore/OptimizelySDKCoreTests/OptimizelyTest.m

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -964,15 +964,6 @@ -(void)testGetEnabledFeaturesWithSomeFeaturesEnabledForUser {
964964
XCTAssertEqualObjects(features, enabledFeatures);
965965
}
966966

967-
// should return sorted feature array as some feature is enabled for user
968-
-(void)testGetEnabledFeaturesSortedWithSomeFeaturesEnabledForUser {
969-
NSArray<NSString *> *sortedEnabledFeatures = @[@"booleanFeature", @"booleanSingleVariableFeature", @"multiVariateFeature"];
970-
NSArray<NSString *> *unSortedEnabledFeatures = @[ @"multiVariateFeature", @"booleanFeature", @"booleanSingleVariableFeature"];
971-
NSArray<NSString *> *features = [self.optimizely getEnabledFeatures:kUserId attributes:self.attributes];
972-
XCTAssertEqualObjects(features, sortedEnabledFeatures);
973-
XCTAssertNotEqualObjects(features, unSortedEnabledFeatures);
974-
}
975-
976967
#pragma mark - Helper Methods
977968

978969
- (id)getOptimizelyMockForFeatureVariableType:(NSString *)featureVariableType variableKey:(NSString *)variableKey expectedReturn:(NSString *)expectedReturn {

OptimizelySDKCore/OptimizelySDKCoreTests/TestData/test_data_10_experiments.json

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -713,29 +713,6 @@
713713
"experimentIds": [],
714714
"variables": []
715715
},
716-
{
717-
"id": "155559",
718-
"key": "multiVariateFeature",
719-
"groupId": "",
720-
"rolloutId": "",
721-
"experimentIds": [
722-
"6358043287"
723-
],
724-
"variables": [
725-
{
726-
"id": "155560",
727-
"key": "firstLetter",
728-
"type": "string",
729-
"defaultValue": "H"
730-
},
731-
{
732-
"id": "155561",
733-
"key": "restOfName",
734-
"type": "string",
735-
"defaultValue": "arry"
736-
}
737-
]
738-
},
739716
{
740717
"id": "155549",
741718
"key": "booleanFeature",
@@ -788,6 +765,29 @@
788765
}
789766
]
790767
},
768+
{
769+
"id": "155559",
770+
"key": "multiVariateFeature",
771+
"groupId": "",
772+
"rolloutId": "",
773+
"experimentIds": [
774+
"6358043287"
775+
],
776+
"variables": [
777+
{
778+
"id": "155560",
779+
"key": "firstLetter",
780+
"type": "string",
781+
"defaultValue": "H"
782+
},
783+
{
784+
"id": "155561",
785+
"key": "restOfName",
786+
"type": "string",
787+
"defaultValue": "arry"
788+
}
789+
]
790+
},
791791
{
792792
"id": "155666",
793793
"key": "doubleSingleVariableFeature",

0 commit comments

Comments
 (0)