Kroach/fixdomwarning (#156)

* Fix 'distributed object modifiers' compiler warning

* Fix 5 Xcode compiler warnings

Summary:
Fix 5 Xcode compiler warnings which have slipped into master branch
Fix 'distributed object modifiers' compiler warning
Fix 'directory not found ... Localytics-iOS-4.2.0' warning.

Test Plan:
Confirm the 5 Xcode compiler warnings go away.  Build and run
the demo app on iOS simulator.  PASSED

Reviewers: alda

Differential Revision: https://phabricator.optimizely.com/D16790

Author: kellyroach-optimizely

OptimizelyDemoApp/OptimizelyDemoApp.xcodeproj/project.pbxproj

@@ -818,7 +818,7 @@
 					"\"${PODS_ROOT}/FirebaseCore/Frameworks\"",
 					"\"${PODS_ROOT}/FirebaseInstanceID/Frameworks\"",
 					"\"${PODS_ROOT}/Google/Frameworks\"",
-					"\"${PODS_ROOT}/Localytics/Localytics-iOS-4.2.0\"",
+					"\"${PODS_ROOT}/Localytics/Localytics-iOS-4.3.2\"",
 				);
 				INFOPLIST_FILE = "$(SRCROOT)/OptimizelyiOSDemoApp/OptimizelyiOSDemoApp-Info.plist";
 				IPHONEOS_DEPLOYMENT_TARGET = 9.0;

OptimizelySDKShared/OptimizelySDKShared/OPTLYClient.m

@@ -198,7 +198,7 @@ - (nullable NSString *)variableString:(nonnull NSString *)variableKey
                                userId:(nonnull NSString *)userId
                            attributes:(nullable NSDictionary *)attributes
                    activateExperiment:(BOOL)activateExperiment
-                                error:(NSError * _Nullable * _Nullable)error {
+                                error:(out NSError * _Nullable * _Nullable)error {
     if (self.optimizely == nil) {
         [self.logger logMessage:OPTLYLoggerMessagesClientDummyOptimizelyError
                       withLevel:OptimizelyLogLevelError];
@@ -254,7 +254,7 @@ - (BOOL)variableBoolean:(nonnull NSString *)variableKey
                  userId:(nonnull NSString *)userId
              attributes:(nullable NSDictionary *)attributes
      activateExperiment:(BOOL)activateExperiment
-                  error:(NSError * _Nullable * _Nullable)error {
+                  error:(out NSError * _Nullable * _Nullable)error {
     if (self.optimizely == nil) {
         [self.logger logMessage:OPTLYLoggerMessagesClientDummyOptimizelyError
                       withLevel:OptimizelyLogLevelError];
@@ -310,7 +310,7 @@ - (NSInteger)variableInteger:(nonnull NSString *)variableKey
                       userId:(nonnull NSString *)userId
                   attributes:(nullable NSDictionary *)attributes
           activateExperiment:(BOOL)activateExperiment
-                       error:(NSError * _Nullable * _Nullable)error {
+                       error:(out NSError * _Nullable * _Nullable)error {
     if (self.optimizely == nil) {
         [self.logger logMessage:OPTLYLoggerMessagesClientDummyOptimizelyError
                       withLevel:OptimizelyLogLevelError];
@@ -366,7 +366,7 @@ - (double)variableDouble:(nonnull NSString *)variableKey
                   userId:(nonnull NSString *)userId
               attributes:(nullable NSDictionary *)attributes
       activateExperiment:(BOOL)activateExperiment
-                   error:(NSError * _Nullable * _Nullable)error {
+                   error:(out NSError * _Nullable * _Nullable)error {
     if (self.optimizely == nil) {
         [self.logger logMessage:OPTLYLoggerMessagesClientDummyOptimizelyError
                       withLevel:OptimizelyLogLevelError];