Skip to content

Commit c92a8fd

Browse files
ci(travis): add mdspell (#443)
1 parent 65c078b commit c92a8fd

File tree

5 files changed

+24
-11
lines changed

5 files changed

+24
-11
lines changed

.travis.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,19 @@ jobs:
4646
notifications:
4747
email: false
4848

49+
- stage: 'Lint markdown files'
50+
language: node_js
51+
node_js: 12
52+
os: linux
53+
before_install: skip
54+
install:
55+
- npm i -g markdown-spellcheck
56+
before_script:
57+
- wget --quiet https://raw.githubusercontent.com/optimizely/mdspell-config/master/.spelling
58+
script:
59+
- mdspell -a -n -r --en-us '**/*.md'
60+
after_success: skip
61+
4962
- stage: 'SourceClear and Lint'
5063
language: objective-c
5164
os: osx

CHANGELOG.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ The primary difference between the new Feature Variable APIs and the older, Vari
191191
To learn more about Feature Management, read our [knowledge base article introducing the feature](https://help.optimizely.com/Set_Up_Optimizely/Develop_a_product_or_feature_with_Feature_Management).
192192

193193
### New Features
194-
* Introduces the `isFeatureEnabled` API, a featue flag used to determine whether to show a feature to a user. The `isFeatureEnabled` should be used in place of the `activate` API to activate experiments running on features. Specifically, calling this API causes the SDK to evaluate all [Feature Tests](https://developers.optimizely.com/x/solutions/sdks/reference/?language=objectivec#activate-feature-tests) and [Rollouts](https://developers.optimizely.com/x/solutions/sdks/reference/?language=objectivec#activate-feature-rollouts) associated with the provided feature key.
194+
* Introduces the `isFeatureEnabled` API, a feature flag used to determine whether to show a feature to a user. The `isFeatureEnabled` should be used in place of the `activate` API to activate experiments running on features. Specifically, calling this API causes the SDK to evaluate all [Feature Tests](https://developers.optimizely.com/x/solutions/sdks/reference/?language=objectivec#activate-feature-tests) and [Rollouts](https://developers.optimizely.com/x/solutions/sdks/reference/?language=objectivec#activate-feature-rollouts) associated with the provided feature key.
195195
```
196196
/**
197197
* Determine whether a feature is enabled.
@@ -270,7 +270,7 @@ with Notification Listeners APIs
270270
### Deprecations
271271
* Version 2.1.0 deprecates the Variable APIs: `variableBoolean`, `variableDouble`, `variableInteger`, and `variableString`
272272

273-
* Replace use of the Variable APIs with Feature Mangement's Feature Variable APIs, described above
273+
* Replace use of the Variable APIs with Feature Management's Feature Variable APIs, described above
274274

275275
* We will continue to support the Variable APIs until the 3.x release, but we encourage you to upgrade as soon as possible
276276

@@ -419,7 +419,7 @@ unable to be deleted from data store due to syntax error.
419419
June 15, 2018
420420

421421
### New Features
422-
* Updated SDK targets to Xcode 9.4 recommended settings, pod update'd third party Cocoapods used by the 2 demo apps,
422+
* Updated SDK targets to Xcode 9.4 recommended settings, pod updated third party Cocoapods used by the 2 demo apps,
423423
and eliminated Xcode 9.4 Build and Analyze warnings for SDK targets.
424424

425425
## 1.5.1
@@ -480,7 +480,7 @@ OPTLYClient * _Nullable client))callback;
480480
```
481481
### Bug Fixes:
482482
* Added `libsqlite3.tbd` to the Shared framework podspec and linked it in the build settings.
483-
* Crash caused by `Fatal Exception: NSRangeException` in `OPTLYHTTPRequestManager.m`. This crash occurred during a backoff retry in a datafile download or event dispatch because data strutures that were not threadsafe (used only for testing) were being modified. To resolve this, the data structures were wrapped in a flag and are only modifiable if unit tests are running.
483+
* Crash caused by `Fatal Exception: NSRangeException` in `OPTLYHTTPRequestManager.m`. This crash occurred during a backoff retry in a datafile download or event dispatch because data structures that were not threadsafe (used only for testing) were being modified. To resolve this, the data structures were wrapped in a flag and are only modifiable if unit tests are running.
484484

485485
### Cleanup:
486486
* Fix migration to Xcode 9.0 compiler warnings regarding "NSError * __autoreleasing *" and "(^)(void) in blocks".

OptimizelySDKShared/OPTLYFMDB/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,11 @@ In addition to the `makeFunctionNamed` noted above, there are a few other API ch
9797

9898
- To become consistent with the rest of the API, the methods `objectForColumnName` and `UTF8StringForColumnName` have been renamed to `objectForColumn` and `UTF8StringForColumn`.
9999

100-
- Note, the `objectForColumn` (and the associted subscript operator) now returns `nil` if an invalid column name/index is passed to it. It used to return `NSNull`.
100+
- Note, the `objectForColumn` (and the associated subscript operator) now returns `nil` if an invalid column name/index is passed to it. It used to return `NSNull`.
101101

102102
- To avoid confusion with `OPTLYFMDBDatabaseQueue` method `inTransaction`, which performs transactions, the `OPTLYFMDBDatabase` method to determine whether you are in a transaction or not, `inTransaction`, has been replaced with a read-only property, `isInTransaction`.
103103

104-
- Several functions have been converted to properties, namely, `databasePath`, `maxBusyRetryTimeInterval`, `shouldCacheStatements`, `sqliteHandle`, `hasOpenResultSets`, `lastInsertRowId`, `changes`, `goodConnection`, `columnCount`, `resultDictionary`, `applicationID`, `applicationIDString`, `userVersion`, `countOfCheckedInDatabases`, `countOfCheckedOutDatabases`, and `countOfOpenDatabases`. For Objective-C users, this has little material impact, but for Swift users, it results in a slightly more natural interface. Note: For Objective-C developers, previously versions of OPTLYFMDB exposed many ivars (but we hope you weren't using them directly, anyway!), but the implmentation details for these are no longer exposed.
104+
- Several functions have been converted to properties, namely, `databasePath`, `maxBusyRetryTimeInterval`, `shouldCacheStatements`, `sqliteHandle`, `hasOpenResultSets`, `lastInsertRowId`, `changes`, `goodConnection`, `columnCount`, `resultDictionary`, `applicationID`, `applicationIDString`, `userVersion`, `countOfCheckedInDatabases`, `countOfCheckedOutDatabases`, and `countOfOpenDatabases`. For Objective-C users, this has little material impact, but for Swift users, it results in a slightly more natural interface. Note: For Objective-C developers, previously versions of OPTLYFMDB exposed many ivars (but we hope you weren't using them directly, anyway!), but the implementation details for these are no longer exposed.
105105

106106
### URL Methods
107107

Pods/Mixpanel-swift/README.md

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -136,24 +136,24 @@ First-party code (under OptimizelySDKCore/, OptimizelySDKDatafileManager/, Optim
136136

137137
**FMDB** [https://github.com/ccgus/fmdb](https://github.com/ccgus/fmdb)
138138
License (MIT):: [https://github.com/ccgus/fmdb/blob/master/LICENSE.txt](https://github.com/ccgus/fmdb/blob/master/LICENSE.txt)
139-
Modfied: Yes
139+
Modified: Yes
140140
Distributed: Yes
141141
Distribution: Binary
142142

143143
**SQLITE3** [https://www.sqlite.org/index.html](https://www.sqlite.org/index.html)
144144
License (Public Domain):: [https://www.sqlite.org/copyright.html](https://www.sqlite.org/copyright.html)
145-
Modfied: Yes
145+
Modified: Yes
146146
Distributed: Yes
147147
Distribution: Binary
148148

149149
**JSONModel** [https://github.com/jsonmodel/jsonmodel](https://github.com/jsonmodel/jsonmodel)
150150
License (MIT):: [https://github.com/jsonmodel/jsonmodel/blob/master/LICENSEl](https://github.com/jsonmodel/jsonmodel/blob/master/LICENSE)
151-
Modfied: Yes
151+
Modified: Yes
152152
Distributed: Yes
153153
Distribution: Binary
154154

155155
**murmur3** [https://github.com/PeterScott/murmur3l](https://github.com/PeterScott/murmur3)
156156
License (Public Domain):: [https://github.com/PeterScott/murmur3l](https://github.com/PeterScott/murmur3)
157-
Modfied: No
157+
Modified: No
158158
Distributed: Yes
159159
Distribution: Binary

0 commit comments

Comments
 (0)