Skip to content

Commit b6d2a84

Browse files
Fixed broken tests.
1 parent 01d0898 commit b6d2a84

File tree

3 files changed

+12
-27
lines changed

3 files changed

+12
-27
lines changed

OptimizelySDKDatafileManager/OptimizelySDKDatafileManager/OPTLYDatafileManager.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@
1515
***************************************************************************/
1616

1717
#import <Foundation/Foundation.h>
18-
#import <OptimizelySDKCore/OPTLYErrorHandler.h>
19-
#import <OptimizelySDKCore/OPTLYLogger.h>
2018
#import <OptimizelySDKShared/OPTLYDatafileManager.h>
19+
#import <OptimizelySDKCore/OPTLYErrorHandler.h>
2120
#import <OptimizelySDKShared/OPTLYHTTPRequestManager.h>
21+
#import <OptimizelySDKCore/OPTLYLogger.h>
2222
#import "OPTLYDatafileManagerBuilder.h"
2323

2424
@protocol OPTLYErrorHandler, OPTLYLogger;

OptimizelySDKDatafileManager/OptimizelySDKDatafileManagerTests/OPTLYDatafileManagerTest.m

Lines changed: 10 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -18,25 +18,18 @@
1818
#import "OPTLYTestHelper.h"
1919
#import <OHHTTPStubs/OHHTTPStubs.h>
2020
#import <OptimizelySDKShared/OPTLYDataStore.h>
21-
#import <OptimizelySDKShared/OPTLYFileManager.h>
22-
23-
24-
@interface OptimizelySDKDatafileManagerTests : XCTestCase
25-
@end
26-
27-
@implementation OptimizelySDKDatafileManagerTests
28-
29-
@property NSString *baseDir;
30-
31-
@end
21+
#import "OPTLYDatafileManager.h"
3222

3323
static NSString *const kProjectId = @"6372300739";
3424
static NSString *const kDatamodelDatafileName = @"datafile_6372300739";
3525

36-
@interface OPTLYDatafileManagerTest : XCTestCase
37-
38-
@property OPTLYDataStore *dataStore;
26+
@interface OPTLYDatafileManager(test)
27+
- (void)saveDatafile:(NSData *)datafile;
28+
@end
3929

30+
@interface OPTLYDatafileManagerTest : XCTestCase
31+
@property (nonatomic, strong) OPTLYDatafileManager *datafileManager;
32+
@property (nonatomic, strong) OPTLYDataStore *dataStore;
4033
@end
4134

4235
@implementation OPTLYDatafileManagerTest
@@ -130,12 +123,12 @@ - (void)testSaveDatafileMethod {
130123
XCTAssertTrue(fileExists, @"save Datafile did not save the datafile to disk");
131124
NSError *error;
132125
NSData *savedData = [self.dataStore getFile:kProjectId
133-
type:OPTLYDataStoreDataTypeDatafile
134-
error:&error];
126+
type:OPTLYDataStoreDataTypeDatafile
127+
error:&error];
135128
XCTAssertNil(error);
136129
XCTAssertNotNil(savedData);
137130
XCTAssertNotEqual(datafile, savedData, @"we should not be referencing the same object. Saved data should be a new NSData object created from disk.");
138-
XCTAssertEqualObjects(datafile, savedData, @"retrieved saved data from disk should be equivilent to the datafile we wanted to save to disk");
131+
XCTAssertEqualObjects(datafile, savedData, @"retrieved saved data from disk should be equivalent to the datafile we wanted to save to disk");
139132
}
140133

141134
- (void)testDatafileManagerDownloadDatafileSavesDatafile {

OptimizelySDKUserProfile/OptimizelySDKUserProfileTests/OptimizelySDKUserProfileTests.m

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,9 @@ - (void)setUp {
4848
}];
4949
[self.userProfile save:kUserId1 experiment:kExperimentKey1 variation:kVariationKey1];
5050
[self.userProfile save:kUserId2 experiment:kExperimentKey2 variation:kVariationKey2];
51-
<<<<<<< HEAD
5251
[self.userProfile save:kUserId3 experiment:kExperimentKey3a variation:kVariationKey3a];
5352
[self.userProfile save:kUserId3 experiment:kExperimentKey3b variation:kVariationKey3b];
5453
[self.userProfile save:kUserId3 experiment:kExperimentKey3c variation:kVariationKey3c];
55-
=======
56-
[self.userProfile save:kUserId3 experiment:kExperimentKey3 variation:kVariationKey3];
57-
>>>>>>> User profile feature.
5854
[super setUp];
5955
}
6056

@@ -69,11 +65,7 @@ - (void)testUserProfileInitWithBuilderBlock
6965
XCTAssert([self.userProfile.logger isKindOfClass:[OPTLYLoggerDefault class]]);
7066
}
7167

72-
<<<<<<< HEAD
7368
- (void)testSaveUserData
74-
=======
75-
- (void)testSave
76-
>>>>>>> User profile feature.
7769
{
7870
NSDictionary *userData = [self.userProfile.dataStore getUserDataForType:OPTLYDataStoreDataTypeUserProfile];
7971
NSArray *users = [userData allKeys];

0 commit comments

Comments
 (0)