change properties to readonly

Author: wangjoshuah

OptimizelySDKDatafileManager/OptimizelySDKDatafileManager/OPTLYDatafileManager.h

@@ -31,7 +31,7 @@
 /// The project ID of the datafile this datafile manager will monitor
 @property (nonatomic, readonly, strong, nonnull) NSString *projectId;
 /// The error handler to be used for the manager, client, and all subcomponents
-@property (nonatomic, readwrite, strong, nullable) id<OPTLYErrorHandler> errorHandler;
+@property (nonatomic, readonly, strong, nullable) id<OPTLYErrorHandler> errorHandler;
 /// A logger for the OPTLYDatafileManager to log messages.
 @property (nonatomic, readonly, strong, nonnull) id<OPTLYLogger> logger;
 

OptimizelySDKDatafileManager/OptimizelySDKDatafileManager/OPTLYDatafileManager.m

@@ -43,7 +43,7 @@ - (instancetype)initWithBuilder:(OPTLYDatafileManagerBuilder *)builder {
             _projectId = builder.projectId;
             _errorHandler = builder.errorHandler;
             _logger = builder.logger;
-            _networkService = [[OPTLYNetworkService alloc] init];
+            _networkService = [OPTLYNetworkService new];
             _dataStore = [OPTLYDataStore new];
 
             // download datafile when we start the datafile manager

OptimizelySDKShared/OptimizelySDKShared/OPTLYManager.h

@@ -26,13 +26,13 @@
 /// The default datafile to initialize an Optimizely Client with
 @property (nonatomic, readwrite, strong, nullable) NSData *datafile;
 /// The datafile manager that will download the datafile for the manager
-@property (nonatomic, readwrite, strong, nullable) id<OPTLYDatafileManager> datafileManager;
+@property (nonatomic, readonly, strong, nullable) id<OPTLYDatafileManager> datafileManager;
 /// The error handler to be used for the manager, client, and all subcomponents
-@property (nonatomic, readwrite, strong, nullable) id<OPTLYErrorHandler> errorHandler;
+@property (nonatomic, readonly, strong, nullable) id<OPTLYErrorHandler> errorHandler;
 /// The event dispatcher to initialize an Optimizely Client with
-@property (nonatomic, readwrite, strong, nullable) id<OPTLYEventDispatcher> eventDispatcher;
+@property (nonatomic, readonly, strong, nullable) id<OPTLYEventDispatcher> eventDispatcher;
 /// The logger to be used for the manager, client, and all subcomponents
-@property (nonatomic, readwrite, strong, nullable) id<OPTLYLogger> logger;
+@property (nonatomic, readonly, strong, nullable) id<OPTLYLogger> logger;
 
 /**
  * Init with builder block