Skip to content

Commit 846563c

Browse files
Added logs related to sticky bucketing.
1 parent d15a73a commit 846563c

File tree

4 files changed

+21
-4
lines changed

4 files changed

+21
-4
lines changed

OptimizelySDKCore/OptimizelySDKCore/OPTLYBucketer.m

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,10 @@ - (OPTLYVariation *)bucketExperiment:(OPTLYExperiment *)experiment
7171
if ([stickyBucketingVariationKey length] > 0) {
7272
OPTLYVariation *stickyBucketingVariation = [self.config getVariationForVariationKey:stickyBucketingVariationKey];
7373
if (stickyBucketingVariation) {
74-
// TODO - Log this
74+
75+
NSString *logMessage = [NSString stringWithFormat:OPTLYLoggerMessagesBucketerUserDataRetrieved, userId, experiment.experimentKey, stickyBucketingVariation.variationKey];
76+
[self.config.logger logMessage:logMessage withLevel:OptimizelyLogLevelDebug];
77+
7578
return stickyBucketingVariation;
7679
}
7780
}
@@ -100,8 +103,12 @@ - (OPTLYVariation *)bucketExperiment:(OPTLYExperiment *)experiment
100103
// bucket to variation only if experiment passes Mutex check
101104
if (experiment != nil) {
102105
OPTLYVariation *variation = [self bucketToVariation:experiment withUserId:userId];
103-
// TODO - log this
104-
[self.config.userProfile save:userId experiment:experiment.experimentKey variation:variation.variationKey];
106+
if (variation) {
107+
[self.config.userProfile save:userId experiment:experiment.experimentKey variation:variation.variationKey];
108+
109+
NSString *logMessage = [NSString stringWithFormat:OPTLYLoggerMessagesBucketerSavingUserData, userId, experiment.experimentKey, variation.variationKey];
110+
[self.config.logger logMessage:logMessage withLevel:OptimizelyLogLevelDebug];
111+
}
105112
return variation;
106113
}
107114
else {

OptimizelySDKCore/OptimizelySDKCore/OPTLYLoggerMessages.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,11 @@ extern NSString *const OPTLYLoggerMessagesUserProfileNoVariation;
128128
extern NSString *const OPTLYLoggerMessagesUserProfileRemoveVariation;
129129
extern NSString *const OPTLYLoggerMessagesUserProfileRemoveVariationNotFound;
130130

131+
// ---- Bucketing ----
132+
// Debug
133+
extern NSString *const OPTLYLoggerMessagesBucketerSavingUserData;
134+
extern NSString *const OPTLYLoggerMessagesBucketerUserDataRetrieved;
135+
131136
@interface OPTLYLoggerMessages : NSObject
132137

133138
@end

OptimizelySDKCore/OptimizelySDKCore/OPTLYLoggerMessages.m

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,11 @@
128128
NSString *const OPTLYLoggerMessagesUserProfileRemoveVariation = @"Removed variation %@ for user %@, experiment %@.";
129129
NSString *const OPTLYLoggerMessagesUserProfileRemoveVariationNotFound = @"Not removing variation for user %@, experiment %@. Variation not found.";
130130

131+
// ---- Bucketing ----
132+
// Debug
133+
NSString *const OPTLYLoggerMessagesBucketerSavingUserData = @"Saving bucketing data for user: %@, experiment: %@, variation: %@.";
134+
NSString *const OPTLYLoggerMessagesBucketerUserDataRetrieved = @"Retrieved bucketing data for user: %@, experiment: %@, variation: %@.";
135+
131136
@implementation OPTLYLoggerMessages
132137

133138
@end

OptimizelyiOSDemoApp/OptimizelyiOSDemoApp/AppDelegate.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
3333
var attributes = ["browser_type" : "firefox"]
3434
var eventKey = "testEventWithAudiences"
3535
var experimentKey = "testExperimentWithFirefoxAudience" // experiment ID: 6383811281
36-
let downloadDatafile = true
36+
let downloadDatafile = false
3737

3838
func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool {
3939

0 commit comments

Comments
 (0)