add error handler to datafile manager class

Author: wangjoshuah

OptimizelySDKDatafileManager/OptimizelySDKDatafileManager/OPTLYDatafileManager.h

@@ -16,10 +16,12 @@
 
 #import <Foundation/Foundation.h>
 #import "OPTLYDatafileManagerBuilder.h"
-#import <OptimizelySDKShared/OPTLYHTTPRequestManager.h>
+#import <OptimizelySDKCore/OPTLYErrorHandler.h>
 #import <OptimizelySDKCore/OPTLYLogger.h>
+#import <OptimizelySDKShared/OPTLYHTTPRequestManager.h>
+
 
-@protocol OPTLYLogger;
+@protocol OPTLYErrorHandler, OPTLYLogger;
 
 @protocol OPTLYDatafileManager <NSObject>
 
@@ -39,6 +41,8 @@
 @property (nonatomic, readonly) NSTimeInterval datafileFetchInterval;
 /// The project ID of the datafile this datafile manager will monitor
 @property (nonatomic, readonly, strong, nonnull) NSString *projectId;
+/// The error handler to be used for the manager, client, and all subcomponents
+@property (nonatomic, readwrite, strong, nullable) id<OPTLYErrorHandler> errorHandler;
 /// A logger for the OPTLYDatafileManager to log messages.
 @property (nonatomic, readonly, strong, nonnull) id<OPTLYLogger> logger;
 

OptimizelySDKDatafileManager/OptimizelySDKDatafileManager/OPTLYDatafileManager.m

@@ -41,6 +41,7 @@ - (instancetype)initWithBuilder:(OPTLYDatafileManagerBuilder *)builder {
             _datafileFetchInterval = kDefaultDatafileFetchInterval;
             _datafileFetchInterval = builder.datafileFetchInterval;
             _projectId = builder.projectId;
+            _errorHandler = builder.errorHandler;
             _logger = builder.logger;
             _networkService = [[OPTLYNetworkService alloc] init];
             _dataStore = [OPTLYDataStore new];
@@ -64,7 +65,7 @@ - (void)downloadDatafile:(NSString *)projectId completionHandler:(OPTLYHTTPReque
     [self.networkService downloadProjectConfig:self.projectId
                              completionHandler:^(NSData * _Nullable data, NSURLResponse * _Nullable response, NSError * _Nullable error) {
                                  if (error != nil) {
-                                     // TODO: Josh W. handle errors
+                                     [self.errorHandler handleError:error];
                                  }
                                  else if ([(NSHTTPURLResponse *)response statusCode] == 200) { // got datafile OK
                                      [self saveDatafile:data];

OptimizelySDKDatafileManager/OptimizelySDKDatafileManager/OPTLYDatafileManagerBuilder.h

@@ -17,7 +17,7 @@
 #import <Foundation/Foundation.h>
 
 @class OPTLYDatafileManagerBuilder;
-@protocol OPTLYLogger;
+@protocol OPTLYErrorHandler, OPTLYLogger;
 
 /// This is a block that takes the biulder values
 typedef void (^OPTLYDatafileManagerBuilderBlock)(OPTLYDatafileManagerBuilder * _Nullable builder);
@@ -30,10 +30,11 @@ typedef void (^OPTLYDatafileManagerBuilderBlock)(OPTLYDatafileManagerBuilder * _
 @property (nonatomic, readwrite) NSTimeInterval datafileFetchInterval;
 /// The projectID of the project we want to get the datafile for.
 @property (nonatomic, readwrite, strong, nonnull) NSString *projectId;
+/// The error handler to be used for the manager, client, and all subcomponents
+@property (nonatomic, readwrite, strong, nullable) id<OPTLYErrorHandler> errorHandler;
 /// A logger to inject for purposes of error logging. If none is passed in, a default logger with log level `All` will be created.
 @property (nonatomic, readwrite, strong, nonnull) id<OPTLYLogger> logger;
 
-
 /// Create an Optimizely Datafile Manager Builder object.
 + (nullable instancetype)builderWithBlock:(nonnull OPTLYDatafileManagerBuilderBlock)block;
 

OptimizelySDKDatafileManager/OptimizelySDKDatafileManager/OPTLYDatafileManagerBuilder.m

@@ -15,6 +15,7 @@
  ***************************************************************************/
 
 #import "OPTLYDatafileManagerBuilder.h"
+#import <OptimizelySDKCore/OPTLYErrorHandler.h>
 #import <OptimizelySDKCore/OPTLYLogger.h>
 #import <OptimizelySDKCore/OPTLYLoggerMessages.h>
 
@@ -62,4 +63,11 @@ - (NSTimeInterval)datafileFetchInterval {
     return _logger;
 }
 
+- (id<OPTLYErrorHandler>)errorHandler {
+    if (!_errorHandler) {
+        _errorHandler = [[OPTLYErrorHandlerNoOp alloc] init];
+    }
+    return _errorHandler;
+}
+
 @end