Renamed property. Alphabetized protocol and class imports.

Author: alda-optimizely

OptimizelySDKCore/OptimizelySDKCore/OPTLYBuilder.h

@@ -47,8 +47,6 @@ typedef void (^OPTLYBuilderBlock)(OPTLYBuilder * _Nullable builder);
 /// User profile stores user-specific data, like bucketing.
 @property (nonatomic, strong, nullable) id<OPTLYUserProfile> userProfile;
 
-@property (nonatomic, strong, nullable) id<OPTLYUserProfile> userProfile;
-
 /// Create an Optimizely Builder object.
 + (nullable instancetype)builderWithBlock:(nonnull OPTLYBuilderBlock)block;
 

OptimizelySDKCore/OptimizelySDKCore/OPTLYEventDispatcher.m

@@ -44,38 +44,6 @@ + (BOOL)conformsToOPTLYEventDispatcherProtocol:(Class)instanceClass
 
 @implementation OPTLYEventDispatcherBasic
 
-- (void)dispatchEvent:(NSDictionary *)params
-                toURL:(NSURL *)url
-    completionHandler:(void(^)(NSURLResponse *response, NSError *error))completion
-{
-    NSURLSession *ephemeralSession = [NSURLSession sessionWithConfiguration:[NSURLSessionConfiguration ephemeralSessionConfiguration]];
-    NSMutableURLRequest *request = [[NSMutableURLRequest alloc] initWithURL:url];
-    [request setHTTPMethod:kHTTPRequestMethodPost];
-    
-    NSError *JSONSerializationError = nil;
-    NSData *data = [NSJSONSerialization dataWithJSONObject:params
-                                                   options:kNilOptions
-                                                     error:&JSONSerializationError];
-    
-    [request addValue:kHTTPHeaderFieldValueApplicationJSON forHTTPHeaderField:kHTTPHeaderFieldContentType];
-    
-    if (!JSONSerializationError) {
-        NSURLSessionUploadTask *uploadTask = [ephemeralSession uploadTaskWithRequest:request
-                                                                            fromData:data
-                                                                   completionHandler:^(NSData *data,NSURLResponse *response,NSError *error) {
-                                                                       if (completion) {
-                                                                           completion(response, error);
-                                                                       }
-                                                                   }];
-        
-        [uploadTask resume];
-    }
-}
-
-@end
-
-@implementation OPTLYEventDispatcherBasic
-
 - (void)dispatchImpressionEvent:(nonnull NSDictionary *)params
                        callback:(nullable void(^)(NSData * _Nullable data, NSURLResponse * _Nullable response, NSError * _Nullable error))callback {
     NSURL *url = [NSURL URLWithString:kEventDispatcherImpressionEventURL];

OptimizelySDKShared/OptimizelySDKShared/OPTLYDatafileManager.m

@@ -26,6 +26,16 @@ @interface OPTLYDatafileManager ()
 @property OPTLYDataStore *dataStore;
 @property OPTLYNetworkService *networkService;
 
++ (BOOL)conformsToOPTLYDatafileManagerProtocol:(Class)instanceClass {
+    // compile time check
+    BOOL isValidProtocolDeclaration = [instanceClass conformsToProtocol:@protocol(OPTLYDatafileManager)];
+    
+    // runtime check
+    BOOL implementsDownloadDatafileMethod = [instanceClass instancesRespondToSelector:@selector(downloadDatafile:completionHandler:)];
+    
+    return isValidProtocolDeclaration && implementsDownloadDatafileMethod;
+}
+
 @end
 
 @implementation OPTLYDatafileManager