Added better logging for datafile download failures. (#179)

Author: alda-optimizely

OptimizelySDKCore/OptimizelySDKCore/OPTLYLoggerMessages.h

@@ -67,6 +67,7 @@ extern NSString *const OPTLYLoggerMessagesDataStoreFileManagerSaveFile;
 
 // ---- Datafile Manager ----
 // debug
+extern NSString *const OPTLYLoggerMessagesDatafileManagerDatafileNotDownloadedInvalidStatusCode;
 extern NSString *const OPTLYLoggerMessagesDatafileManagerDatafileNotDownloadedError;
 extern NSString *const OPTLYLoggerMessagesDatafileManagerDatafileNotDownloadedNoChanges;
 extern NSString *const OPTLYLoggerMessagesDatafileManagerLastModifiedDate;

OptimizelySDKCore/OptimizelySDKCore/OPTLYLoggerMessages.m

@@ -63,6 +63,7 @@
 
 // ---- Datafile Manager ----
 // debug
+NSString *const OPTLYLoggerMessagesDatafileManagerDatafileNotDownloadedInvalidStatusCode = @"[DATAFILE MANAGER] Datafile for project %@ NOT downloaded. Invalid status code %d.";
 NSString *const OPTLYLoggerMessagesDatafileManagerDatafileNotDownloadedError = @"[DATAFILE MANAGER] Datafile for project %@ NOT downloaded. Error received: %@.";
 NSString *const OPTLYLoggerMessagesDatafileManagerDatafileNotDownloadedNoChanges = @"[DATAFILE MANAGER] Datafile for project %@ NOT downloaded. No datafile changes have been made.";
 NSString *const OPTLYLoggerMessagesDatafileManagerLastModifiedDateFound = @"[DATAFILE MANAGER] Last modified date %@ found for project %@.";

OptimizelySDKDatafileManager/OptimizelySDKDatafileManager/OPTLYDatafileManager.m

@@ -90,6 +90,8 @@ - (void)downloadDatafile:(NSString *)projectId completionHandler:(OPTLYHTTPReque
                                  NSString *logMessage = @"";
                                  if (error != nil) {
                                      [self.errorHandler handleError:error];
+                                     logMessage = [NSString stringWithFormat:OPTLYLoggerMessagesDatafileManagerDatafileNotDownloadedError, projectId, error];
+                                     [self.logger logMessage:logMessage withLevel:OptimizelyLogLevelDebug];
                                  }
                                  else if (statusCode == 200) { // got datafile OK
                                      [self saveDatafile:data];
@@ -106,14 +108,11 @@ - (void)downloadDatafile:(NSString *)projectId completionHandler:(OPTLYHTTPReque
                                      logMessage = [NSString stringWithFormat:OPTLYLoggerMessagesDatafileManagerDatafileNotDownloadedNoChanges, projectId];
                                      [self.logger logMessage:logMessage withLevel:OptimizelyLogLevelDebug];
                                  }
-                                 else {
-                                     // TODO: Josh W. handle bad response
-                                     logMessage = [NSString stringWithFormat:OPTLYLoggerMessagesDatafileManagerDatafileNotDownloadedError, projectId, error];
+                                 else { // no error, but invalid status code
+                                     logMessage = [NSString stringWithFormat:OPTLYLoggerMessagesDatafileManagerDatafileNotDownloadedInvalidStatusCode, projectId, statusCode];
                                      [self.logger logMessage:logMessage withLevel:OptimizelyLogLevelDebug];
                                  }
-                                 
-                                 
-                                 
+                     
                                  // call the completion handler
                                  if (completion != nil) {
                                      completion(data, response, error);