* add OPTLYFileManager.h to OptimizelySDKShared.h umbrella header

 * remove duplicate initWithBaseDir call in OPTLYDatabase class
 * add setup and teardown to OPTLYDatafileManagerTest
 * check the datafilemanager does not have a datafile stored before we
   utilize the save datafile method

Author: wangjoshuah

OptimizelySDKDatafileManager/OptimizelySDKDatafileManagerTests/OPTLYDatafileManagerTest.m

@@ -14,10 +14,6 @@
 
 #import "OPTLYDatafileManager.h"
 
-@interface OPTLYDatafileManagerTest : XCTestCase
-
-@end
-
 @interface OPTLYDatafileManager ()
 
 - (void)saveDatafile:(NSData *)datafile;
@@ -40,8 +36,47 @@ @interface OPTLYFileManager ()
 static NSString *const kProjectId = @"6372300739";
 static NSString *const kDatamodelDatafileName = @"datafile_6372300739";
 
+@interface OPTLYDatafileManagerTest : XCTestCase
+
+@property OPTLYDataStore *dataStore;
+
+@end
+
 @implementation OPTLYDatafileManagerTest
 
++ (void)setUp {
+    [super setUp];
+    
+    // stub all requests
+    [OHHTTPStubs stubRequestsPassingTest:^BOOL(NSURLRequest * _Nonnull request) {
+        // every requests passes this test
+        return true;
+    } withStubResponse:^OHHTTPStubsResponse * _Nonnull(NSURLRequest * _Nonnull request) {
+        // return bad request
+        return [OHHTTPStubsResponse responseWithData:[[NSData alloc] init]
+                                          statusCode:400
+                                             headers:@{@"Content-Type":@"application/json"}];
+    }];
+}
+
++ (void)tearDown {
+    [super tearDown];
+    // make sure we have removed all stubs
+    [OHHTTPStubs removeAllStubs];
+}
+
+- (void)setUp {
+    [super setUp];
+    self.dataStore = [OPTLYDataStore new];
+    [self.dataStore removeAll:nil];
+}
+
+- (void)tearDown {
+    [super tearDown];
+    [self.dataStore removeAll:nil];
+    self.dataStore = nil;
+}
+
 - (void)testRequestDatafileHandlesCompletionEvenWithBadRequest {
     // setup datafile manager
     OPTLYDatafileManager *datafileManager = [OPTLYDatafileManager initWithBuilderBlock:^(OPTLYDatafileManagerBuilder * _Nullable builder) {
@@ -79,12 +114,14 @@ - (void)testRequestDatafileHandlesCompletionEvenWithBadRequest {
     [OHHTTPStubs removeStub:stub];
 }
 
-- (void)testSaveDatafile {
-    // setup datafile manager
+- (void)testSaveDatafileMethod {
+    // setup datafile manager and datastore
+    OPTLYDataStore *dataStore = [OPTLYDataStore new];
     OPTLYDatafileManager *datafileManager = [OPTLYDatafileManager initWithBuilderBlock:^(OPTLYDatafileManagerBuilder * _Nullable builder) {
         builder.projectId = kProjectId;
     }];
     XCTAssertNotNil(datafileManager);
+    XCTAssertFalse([dataStore fileExists:kProjectId type:OPTLYDataStoreDataTypeDatafile]);
 
     // get the datafile
     NSData *datafile = [OPTLYTestHelper loadJSONDatafileIntoDataObject:kDatamodelDatafileName];
@@ -93,8 +130,6 @@ - (void)testSaveDatafile {
     [datafileManager saveDatafile:datafile];
 
     // test the datafile was saved correctly
-    // check file storage
-    OPTLYDataStore *dataStore = [OPTLYDataStore new];
     bool fileExists = [dataStore fileExists:kProjectId type:OPTLYDataStoreDataTypeDatafile];
     XCTAssertTrue(fileExists, @"save Datafile did not save the datafile to disk");
     NSError *error;
@@ -106,4 +141,13 @@ - (void)testSaveDatafile {
     XCTAssertNotEqual(datafile, savedData, @"we should not be referencing the same object. Saved data should be a new NSData object created from disk.");
     XCTAssertEqualObjects(datafile, savedData, @"retrieved saved data from disk should be equivilent to the datafile we wanted to save to disk");
 }
+
+- (void)testDatafileManagerPullsDatafileOnInitialization {
+    // setup stubbing
+    
+    // instantiate datafile manager (it should fire off a request)
+    
+    
+}
+
 @end

OptimizelySDKShared/OptimizelySDKShared/OPTLYDatabase.h

@@ -44,14 +44,6 @@
 - (void)createTable:(nonnull NSString *)tableName
               error:(NSError * _Nullable * _Nullable)error;
 
-/**
- * File manager initializer.
- *
- * @param baseDir The base directory where the database will be stored.
- * @return an instance of OPTLYDatabase.
- **/
-- (nullable instancetype)initWithBaseDir:(nonnull NSString *)baseDir;
-
 /**
  * Inserts data into a database table.
  *

OptimizelySDKShared/OptimizelySDKShared/OptimizelySDKShared.h

@@ -20,6 +20,7 @@
 #import "OPTLYNetworkService.h"
 #import "OPTLYDataStore.h"
 #import "OPTLYClient.h"
+#import "OPTLYFileManager.h"
 #if TARGET_OS_IOS
 #import "OPTLYDatabase.h"
 #import "OPTLYDatabaseEntity.h"