Skip to content

Commit 214041d

Browse files
wangjoshuahalda-optimizely
authored andcommitted
make sure we don't crash with bad access error when we initialize core optimizely with nil builder
1 parent 6e049d0 commit 214041d

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

OptimizelySDKCore/OptimizelySDKCore/OPTLYBuilder.m

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,10 @@ - (id)init {
3333
}
3434

3535
- (id)initWithBlock:(OPTLYBuilderBlock)block {
36+
// check for nil block
37+
if (block == nil) {
38+
return nil;
39+
}
3640
self = [super init];
3741
if (self != nil) {
3842
block(self);

OptimizelySDKCore/OptimizelySDKCoreTests/OPTLYBuilderTest.m

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,4 +108,9 @@ - (void)testBuilderCanAssignLogger {
108108
XCTAssertEqual(logger, customOptimizely.logger, @"Should be the same object with custom builder");
109109
}
110110

111+
- (void)testInitializationWithoutBuilder {
112+
Optimizely *optimizely = [Optimizely initWithBuilderBlock:nil];
113+
XCTAssertNil(optimizely);
114+
}
115+
111116
@end

0 commit comments

Comments
 (0)