Skip to content

Commit 6ba9b55

Browse files
author
Josh Deffibaugh
committed
Removes ProjectConfig param from persistent bucketer save method
1 parent 20c1cd0 commit 6ba9b55

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

core-api/src/main/java/com/optimizely/ab/bucketing/Bucketer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ private Variation bucketToVariation(@Nonnull Experiment experiment,
138138

139139
// If a persistent bucketer instance is present give it a variation to store
140140
if (persistentBucketer != null) {
141-
boolean saved = persistentBucketer.saveActivation(projectConfig, userId, experiment, bucketedVariation);
141+
boolean saved = persistentBucketer.saveActivation(userId, experiment, bucketedVariation);
142142
if (saved) {
143143
logger.info("Persisted variation \"{}\" of experiment \"{}\".", bucketedVariation.getKey(), experimentKey);
144144
} else {

core-api/src/main/java/com/optimizely/ab/bucketing/PersistentBucketer.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
*
2121
* Likewise, when the initial bucketing occurs the default Optimizely {@link Bucketer} will provide
2222
* the {@link ProjectConfig projectConfig}, userId, {@link Experiment}, and
23-
* {@link Variation} to {@link this#saveActivation(ProjectConfig, String, Experiment, Variation)}.
23+
* {@link Variation} to {@link this#saveActivation(String, Experiment, Variation)}.
2424
* These parameters should provide enough data to persist the activation and restore an instance of
2525
* {@link Variation}
2626
*
@@ -34,13 +34,12 @@ public interface PersistentBucketer {
3434

3535
/**
3636
* Called after bucketing occurs, providing a chance to persist data about the activation
37-
* @param projectConfig an instance of {@link ProjectConfig}
3837
* @param userId a String representing a user ID
3938
* @param experiment an {@link Experiment} instance
4039
* @param variation a {@link Variation} id
4140
* @return true if saved otherwise false
4241
*/
43-
boolean saveActivation(ProjectConfig projectConfig, String userId, Experiment experiment, Variation variation);
42+
boolean saveActivation(String userId, Experiment experiment, Variation variation);
4443

4544
/**
4645
* Called before bucketing occurs, providing a chance to restore a previously bucketed {@link Variation}

0 commit comments

Comments
 (0)