Skip to content

Commit 3c14dde

Browse files
authored
fix: Fixed ODP Event type and Json Parser log levels (#495)
## Summary 1. Changed default event type from `client_initialized` to `identified`. 2. Changed Parser log levels from `info` to `debug`. ## Test plan - Manually tested thoroughly. - All existing unit tests and FSC test pass. ## Issues https://jira.sso.episerver.net/browse/FSSDK-8725 https://jira.sso.episerver.net/browse/FSSDK-8726
1 parent c68a554 commit 3c14dde

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

core-api/src/main/java/com/optimizely/ab/internal/JsonParserProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public static JsonParserProvider getDefaultParser() {
6464
continue;
6565
}
6666

67-
logger.info("using json parser: {}", parser.className);
67+
logger.debug("using json parser: {}", parser.className);
6868
return parser;
6969
}
7070

core-api/src/main/java/com/optimizely/ab/odp/ODPEventManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public void identifyUser(@Nullable String vuid, @Nullable String userId) {
9191
if (userId != null) {
9292
identifiers.put(ODPUserKey.FS_USER_ID.getKeyString(), userId);
9393
}
94-
ODPEvent event = new ODPEvent("fullstack", "client_initialized", identifiers, null);
94+
ODPEvent event = new ODPEvent("fullstack", "identified", identifiers, null);
9595
sendEvent(event);
9696
}
9797

core-api/src/main/java/com/optimizely/ab/odp/parser/ResponseJsonParserFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public static ResponseJsonParser getParser() {
4343
jsonParser = new JsonSimpleParser();
4444
break;
4545
}
46-
logger.info("Using " + parserProvider.toString() + " parser");
46+
logger.debug("Using " + parserProvider.toString() + " parser");
4747
return jsonParser;
4848
}
4949
}

core-api/src/test/java/com/optimizely/ab/odp/ODPEventManagerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ public void prepareCorrectPayloadForIdentifyUser() throws InterruptedException {
204204
for (int i = 0; i < events.length(); i++) {
205205
JSONObject event = events.getJSONObject(i);
206206
assertEquals("fullstack", event.getString("type"));
207-
assertEquals("client_initialized", event.getString("action"));
207+
assertEquals("identified", event.getString("action"));
208208
assertEquals("the-vuid-" + i, event.getJSONObject("identifiers").getString("vuid"));
209209
assertEquals("the-fs-user-id-" + i, event.getJSONObject("identifiers").getString("fs_user_id"));
210210
assertEquals("sdk", event.getJSONObject("data").getString("data_source_type"));

0 commit comments

Comments
 (0)