Skip to content

Commit 3b3bb9a

Browse files
fix: decision metadata enabled fix. (#410)
1 parent b551357 commit 3b3bb9a

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

core-api/src/main/java/com/optimizely/ab/Optimizely.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -252,10 +252,10 @@ private void sendImpression(@Nonnull ProjectConfig projectConfig,
252252
* @param ruleType It can either be experiment in case impression event is sent from activate or it's feature-test or rollout
253253
*/
254254
private void sendImpression(@Nonnull ProjectConfig projectConfig,
255-
@Nonnull Experiment experiment,
255+
@Nullable Experiment experiment,
256256
@Nonnull String userId,
257257
@Nonnull Map<String, ?> filteredAttributes,
258-
@Nonnull Variation variation,
258+
@Nullable Variation variation,
259259
@Nonnull String flagKey,
260260
@Nonnull String ruleType,
261261
@Nonnull boolean enabled) {
@@ -425,15 +425,6 @@ private Boolean isFeatureEnabled(@Nonnull ProjectConfig projectConfig,
425425
if (featureDecision.decisionSource != null) {
426426
decisionSource = featureDecision.decisionSource;
427427
}
428-
sendImpression(
429-
projectConfig,
430-
featureDecision.experiment,
431-
userId,
432-
copiedAttributes,
433-
featureDecision.variation,
434-
featureKey,
435-
decisionSource.toString(),
436-
featureEnabled);
437428

438429
if (featureDecision.variation != null) {
439430
// This information is only necessary for feature tests.
@@ -448,6 +439,15 @@ private Boolean isFeatureEnabled(@Nonnull ProjectConfig projectConfig,
448439
featureEnabled = true;
449440
}
450441
}
442+
sendImpression(
443+
projectConfig,
444+
featureDecision.experiment,
445+
userId,
446+
copiedAttributes,
447+
featureDecision.variation,
448+
featureKey,
449+
decisionSource.toString(),
450+
featureEnabled);
451451

452452
DecisionNotification decisionNotification = DecisionNotification.newFeatureDecisionNotificationBuilder()
453453
.withUserId(userId)

0 commit comments

Comments
 (0)