Skip to content

Commit 32c4d15

Browse files
authored
make status optional in the creation of live variables (#126)
1 parent b068572 commit 32c4d15

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

core-api/src/main/java/com/optimizely/ab/config/LiveVariable.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,12 @@ public LiveVariable(@JsonProperty("id") String id,
111111
this.id = id;
112112
this.key = key;
113113
this.defaultValue = defaultValue;
114-
this.status = status;
114+
if (status == null) {
115+
this.status = VariableStatus.ACTIVE;
116+
}
117+
else {
118+
this.status = status;
119+
}
115120
this.type = type;
116121
}
117122

core-api/src/test/java/com/optimizely/ab/config/ValidProjectConfigV4.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public class ValidProjectConfigV4 {
7474
VARIABLE_DOUBLE_VARIABLE_ID,
7575
VARIABLE_DOUBLE_VARIABLE_KEY,
7676
VARIABLE_DOUBLE_DEFAULT_VALUE,
77-
LiveVariable.VariableStatus.ACTIVE,
77+
null,
7878
LiveVariable.VariableType.DOUBLE
7979
);
8080
private static final FeatureFlag FEATURE_FLAG_SINGLE_VARIABLE_DOUBLE = new FeatureFlag(
@@ -95,7 +95,7 @@ public class ValidProjectConfigV4 {
9595
VARIABLE_INTEGER_VARIABLE_ID,
9696
VARIABLE_INTEGER_VARIABLE_KEY,
9797
VARIABLE_INTEGER_DEFAULT_VALUE,
98-
LiveVariable.VariableStatus.ACTIVE,
98+
null,
9999
LiveVariable.VariableType.INTEGER
100100
);
101101
private static final FeatureFlag FEATURE_FLAG_SINGLE_VARIABLE_INTEGER = new FeatureFlag(
@@ -116,7 +116,7 @@ public class ValidProjectConfigV4 {
116116
VARIABLE_BOOLEAN_VARIABLE_ID,
117117
VARIABLE_BOOLEAN_VARIABLE_KEY,
118118
VARIABLE_BOOLEAN_VARIABLE_DEFAULT_VALUE,
119-
LiveVariable.VariableStatus.ACTIVE,
119+
null,
120120
LiveVariable.VariableType.BOOLEAN
121121
);
122122
private static final FeatureFlag FEATURE_FLAG_SINGLE_VARIABLE_BOOLEAN = new FeatureFlag(
@@ -137,7 +137,7 @@ public class ValidProjectConfigV4 {
137137
VARIABLE_STRING_VARIABLE_ID,
138138
VARIABLE_STRING_VARIABLE_KEY,
139139
VARIABLE_STRING_VARIABLE_DEFAULT_VALUE,
140-
LiveVariable.VariableStatus.ACTIVE,
140+
null,
141141
LiveVariable.VariableType.STRING
142142
);
143143
private static final FeatureFlag FEATURE_FLAG_SINGLE_VARIABLE_STRING = new FeatureFlag(
@@ -158,7 +158,7 @@ public class ValidProjectConfigV4 {
158158
VARIABLE_FIRST_LETTER_ID,
159159
VARIABLE_FIRST_LETTER_KEY,
160160
VARIABLE_FIRST_LETTER_DEFAULT_VALUE,
161-
LiveVariable.VariableStatus.ACTIVE,
161+
null,
162162
LiveVariable.VariableType.STRING
163163
);
164164
private static final String VARIABLE_REST_OF_NAME_ID = "4052219963";
@@ -168,7 +168,7 @@ public class ValidProjectConfigV4 {
168168
VARIABLE_REST_OF_NAME_ID,
169169
VARIABLE_REST_OF_NAME_KEY,
170170
VARIABLE_REST_OF_NAME_DEFAULT_VALUE,
171-
LiveVariable.VariableStatus.ACTIVE,
171+
null,
172172
LiveVariable.VariableType.STRING
173173
);
174174
private static final FeatureFlag FEATURE_FLAG_MULTI_VARIATE_FEATURE = new FeatureFlag(

0 commit comments

Comments
 (0)