Skip to content

Commit 89a8fde

Browse files
msohailhussainMichael Ng
authored andcommitted
fix: Defined constant for net40 (#180)
1 parent 3c3d6c0 commit 89a8fde

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

OptimizelySDK.Net40/OptimizelySDK.Net40.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<DebugType>full</DebugType>
2020
<Optimize>false</Optimize>
2121
<OutputPath>bin\Debug\</OutputPath>
22-
<DefineConstants>TRACE;DEBUG;NET35</DefineConstants>
22+
<DefineConstants>TRACE;DEBUG;NET35;NET40</DefineConstants>
2323
<ErrorReport>prompt</ErrorReport>
2424
<WarningLevel>4</WarningLevel>
2525
</PropertyGroup>

OptimizelySDK/Config/HttpProjectConfigManager.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ private string GetRemoteDatafileResponse()
7878

7979
return content.Result;
8080
}
81-
#elif NET40
81+
#elif NET40
8282
private string GetRemoteDatafileResponse()
8383
{
8484
var request = (System.Net.HttpWebRequest)System.Net.WebRequest.Create(Url);
@@ -87,8 +87,7 @@ private string GetRemoteDatafileResponse()
8787
if (!string.IsNullOrEmpty(LastModifiedSince))
8888
request.Headers.Add("If-Modified-Since", LastModifiedSince);
8989
var result = (System.Net.HttpWebResponse)request.GetResponse();
90-
91-
// TODO: Need to revise this code.
90+
9291
if (result.StatusCode != System.Net.HttpStatusCode.OK) {
9392
Logger.Log(LogLevel.ERROR, "Unexpected response from event endpoint, status: " + result.StatusCode);
9493
}

0 commit comments

Comments
 (0)