Skip to content

Commit 7ba5a66

Browse files
msohailhussainmikeproeng37
authored andcommitted
fix(whitelistng): Removed logic from bucketing, Decision service is already checking whitelisted. (#98)
1 parent 32c0dca commit 7ba5a66

File tree

2 files changed

+0
-38
lines changed

2 files changed

+0
-38
lines changed

OptimizelySDK.Tests/BucketerTest.cs

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -165,30 +165,6 @@ public void TestBucketInvalidExperiment()
165165
LoggerMock.Verify(l => l.Log(It.IsAny<LogLevel>(), It.IsAny<string>()), Times.Never);
166166
}
167167

168-
[Test]
169-
public void TestBucketValidExperimentNotInGroupUserInForcedVariation()
170-
{
171-
var bucketer = new Bucketer(LoggerMock.Object);
172-
173-
Assert.AreEqual(new Variation { Id = "7722370027", Key = "control" },
174-
bucketer.Bucket(Config, Config.GetExperimentFromKey("test_experiment"), TestBucketingIdControl, "user1"));
175-
176-
LoggerMock.Verify(l => l.Log(LogLevel.INFO, "User [user1] is forced into variation [control]."));
177-
LoggerMock.Verify(l => l.Log(It.IsAny<LogLevel>(), It.IsAny<string>()), Times.Exactly(1));
178-
}
179-
180-
[Test]
181-
public void TestBucketValidExperimentInGroupUserInForcedVariation()
182-
{
183-
var bucketer = new Bucketer(LoggerMock.Object);
184-
185-
Assert.AreEqual(new Variation { Id = "7722260071", Key = "group_exp_1_var_1" },
186-
bucketer.Bucket(Config, Config.GetExperimentFromKey("group_experiment_1"), TestBucketingIdControl, "user1"));
187-
188-
LoggerMock.Verify(l => l.Log(LogLevel.INFO, "User [user1] is forced into variation [group_exp_1_var_1]."));
189-
LoggerMock.Verify(l => l.Log(It.IsAny<LogLevel>(), It.IsAny<string>()), Times.Exactly(1));
190-
}
191-
192168
[Test]
193169
public void TestBucketWithBucketingId()
194170
{

OptimizelySDK/Bucketing/Bucketer.cs

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -112,20 +112,6 @@ public virtual Variation Bucket(ProjectConfig config, Experiment experiment, str
112112
if (string.IsNullOrEmpty(experiment.Key))
113113
return new Variation();
114114

115-
// Check if user is whitelisted for a variation.
116-
var forcedVariations = experiment.ForcedVariations;
117-
if (forcedVariations != null && forcedVariations.ContainsKey(userId))
118-
{
119-
string variationKey = forcedVariations[userId];
120-
variation = config.GetVariationFromKey(experiment.Key, variationKey);
121-
if (!string.IsNullOrEmpty(variationKey))
122-
{
123-
message = string.Format("User [{0}] is forced into variation [{1}].", userId, variationKey);
124-
Logger.Log(LogLevel.INFO, message);
125-
}
126-
return variation;
127-
}
128-
129115
// Determine if experiment is in a mutually exclusive group.
130116
if (experiment.IsInMutexGroup)
131117
{

0 commit comments

Comments
 (0)