Skip to content

Commit 5dd655d

Browse files
mfahadahmedmikeproeng37
authored andcommitted
Removes sorting from GetEnabledFeatures method. (#73)
1 parent 6472076 commit 5dd655d

File tree

4 files changed

+1
-47
lines changed

4 files changed

+1
-47
lines changed

OptimizelySDK.Tests/OptimizelyTest.cs

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1811,39 +1811,6 @@ public void TestGetEnabledFeaturesWithSomeFeaturesEnabledForUser()
18111811
Array.ForEach(notEnabledFeatures, nef => CollectionAssert.DoesNotContain(actualFeaturesList, nef));
18121812
}
18131813

1814-
[Test]
1815-
public void TestGetEnabledFeaturesReturnsSortedList()
1816-
{
1817-
string[] unsortedFeaturesList =
1818-
{
1819-
"Double_single_variable_feature_ignorecase",
1820-
"double_single_variable_feature",
1821-
"boolean_feature",
1822-
"string_single_variable_feature",
1823-
"multi_variate_feature",
1824-
"empty_feature",
1825-
"boolean_single_variable_feature"
1826-
};
1827-
string[] sortedFeaturesList =
1828-
{
1829-
"boolean_feature",
1830-
"boolean_single_variable_feature",
1831-
"double_single_variable_feature",
1832-
//It must come first, if case-sensitive sorted otherwise should come at 4th place
1833-
"Double_single_variable_feature_ignorecase",
1834-
"empty_feature",
1835-
"multi_variate_feature",
1836-
"string_single_variable_feature",
1837-
};
1838-
1839-
OptimizelyMock.Setup(om => om.IsFeatureEnabled(It.IsIn<string>(unsortedFeaturesList), TestUserId,
1840-
It.IsAny<UserAttributes>())).Returns(true);
1841-
1842-
// Verify that returned list in sorterd in ascending order.
1843-
var actualFeaturesList = OptimizelyMock.Object.GetEnabledFeatures(TestUserId, null);
1844-
CollectionAssert.AreEqual(sortedFeaturesList, actualFeaturesList);
1845-
}
1846-
18471814
#endregion // Test GetEnabledFeatures
18481815
}
18491816
}

OptimizelySDK.Tests/ProjectConfigTest.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,6 @@ public void TestInit()
356356
{
357357
{ "boolean_feature", Config.GetFeatureFlagFromKey("boolean_feature") },
358358
{ "double_single_variable_feature", Config.GetFeatureFlagFromKey("double_single_variable_feature") },
359-
{ "Double_single_variable_feature_ignorecase", Config.GetFeatureFlagFromKey("Double_single_variable_feature_ignorecase") },
360359
{ "integer_single_variable_feature", Config.GetFeatureFlagFromKey("integer_single_variable_feature") },
361360
{ "boolean_single_variable_feature", Config.GetFeatureFlagFromKey("boolean_single_variable_feature") },
362361
{ "string_single_variable_feature", Config.GetFeatureFlagFromKey("string_single_variable_feature") },

OptimizelySDK.Tests/TestData.json

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -434,18 +434,7 @@
434434
"rolloutId": "",
435435
"experimentIds": ["7723330021", "7718750065"],
436436
"variables": []
437-
},
438-
{
439-
"id": "1555892",
440-
"key": "Double_single_variable_feature_ignorecase",
441-
"rolloutId": "",
442-
"experimentIds": [
443-
"7723330021",
444-
"7718750065"
445-
],
446-
"variables": []
447-
},
448-
{
437+
}, {
449438
"id": "155550",
450439
"key": "double_single_variable_feature",
451440
"rolloutId": "",

OptimizelySDK/Optimizely.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -591,7 +591,6 @@ public List<string> GetEnabledFeatures(string userId, UserAttributes userAttribu
591591
enabledFeaturesList.Add(featureKey);
592592
}
593593

594-
enabledFeaturesList.Sort(StringComparer.OrdinalIgnoreCase);
595594
return enabledFeaturesList;
596595
}
597596

0 commit comments

Comments
 (0)