fix(framework): Deprecating old frameworks. (#195)

Author: msohailhussain

OptimizelySDK.Net40/OptimizelySDK.Net40.csproj

@@ -19,7 +19,7 @@
     <DebugType>full</DebugType>
     <Optimize>false</Optimize>
     <OutputPath>bin\Debug\</OutputPath>
-    <DefineConstants>TRACE;DEBUG;NET35;NET40</DefineConstants>
+    <DefineConstants>TRACE;DEBUG;NET40</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
   </PropertyGroup>

OptimizelySDK.NetStandard16/OptimizelySDK.NetStandard16.csproj

@@ -10,7 +10,7 @@
     <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     </PropertyGroup>
 	<PropertyGroup>
-    	<DefineConstants>;$(DefineConstants);<NETSTANDARD>NetStandardIdentifier</NETSTANDARD>
+    	<DefineConstants>;$(DefineConstants);<NETSTANDARD1_6>NetStandardIdentifier</NETSTANDARD1_6>
     	</DefineConstants>
 	</PropertyGroup>
     <ItemGroup>

OptimizelySDK/Event/Builder/EventBuilder.cs

@@ -23,6 +23,7 @@
 
 namespace OptimizelySDK.Event.Builder
 {
+    [Obsolete("This class is deprecated. Use 'OptimizelySDK.Event.EventFactory'.")]
     public class EventBuilder
     {
         private const string IMPRESSION_ENDPOINT = "https://logx.optimizely.com/v1/events";

OptimizelySDK/Event/Builder/Params.cs

@@ -13,8 +13,11 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+using System;
+
 namespace OptimizelySDK.Event.Builder
 {
+    [Obsolete("This class is deprecated.")]
     public static class Params
     {
         public const string ACCOUNT_ID          = "account_id";

OptimizelySDK/Optimizely.cs

@@ -30,6 +30,11 @@
 
 namespace OptimizelySDK
 {
+#if NET35
+    [Obsolete("Net3.5 SDK support is deprecated, use NET4.0 or above")]
+#elif NETSTANDARD1_6
+    [Obsolete("Net standard 1.6 SDK support is deprecated, use Net standard 2.0 or above")]
+#endif
     public class Optimizely : IOptimizely, IDisposable
     {
         private Bucketer Bucketer;
@@ -67,7 +72,7 @@ public static String SDK_VERSION
             get
             {
                 // Example output: "2.1.0" .  Should be kept in synch with NuGet package version.
-#if NET35
+#if NET35 || NET40
                 Assembly assembly = Assembly.GetExecutingAssembly();
 #else
                 Assembly assembly = typeof(Optimizely).GetTypeInfo().Assembly;
@@ -423,7 +428,7 @@ public Variation GetForcedVariation(string experimentKey, string userId)
             return DecisionService.GetForcedVariation(experimentKey, userId, config);
         }
 
-        #region  FeatureFlag APIs
+#region  FeatureFlag APIs
 
         /// <summary>
         /// Determine whether a feature is enabled.
@@ -719,7 +724,7 @@ public List<string> GetEnabledFeatures(string userId, UserAttributes userAttribu
             return enabledFeaturesList;
         }
 
-        #endregion // FeatureFlag APIs
+#endregion // FeatureFlag APIs
 
         /// <summary>
         /// Validate all string inputs are not null or empty.

OptimizelySDK/Utils/Schema.cs

@@ -26,7 +26,7 @@ public static string GetSchemaJson()
         {
             if (cache != null)
                 return cache;
-#if NET35
+#if NET35 || NET40
             var assembly = Assembly.GetExecutingAssembly();
 #else
             var assembly = typeof(Schema).GetTypeInfo().Assembly;

OptimizelySDK/Utils/Validator.cs

@@ -32,7 +32,7 @@ public static class Validator
         /// <param name="configJson">ProjectConfig JSON</param>
         /// <param name="schemaJson">Schema JSON for ProjectConfig.  If none is provided, use the one already in the project</param>
         /// <returns>Whether the ProjectConfig is valid</returns>
-#if !NET35
+#if !NET35 && !NET40
         public static bool ValidateJSONSchema(string configJson, string schemaJson = null)
         {
             try
@@ -49,7 +49,8 @@ public static bool ValidateJSONSchema(string configJson, string schemaJson = nul
             }
         }
 #endif
-#if NET35
+
+#if NET35 || NET40
         public static bool ValidateJSONSchema(string configJson, string schemaJson = null)
         {
             return true;