pkg/scaffold: remove TODO for metrics port (#679)

hasbro17 · web-flow · commit 8928eb789949 · 2018-11-01T10:43:17.000-07:00
diff --git a/pkg/scaffold/cmd.go b/pkg/scaffold/cmd.go
@@ -67,9 +67,6 @@ func main() {
 		log.Fatalf("failed to get watch namespace: %v", err)
 	}
 
-	// TODO: Expose metrics port after SDK uses controller-runtime's dynamic client
-	// sdk.ExposeMetricsPort()
-
 	// Get a config to talk to the apiserver
 	cfg, err := config.GetConfig()
 	if err != nil {
diff --git a/pkg/scaffold/cmd_test.go b/pkg/scaffold/cmd_test.go
@@ -63,9 +63,6 @@ func main() {
 		log.Fatalf("failed to get watch namespace: %v", err)
 	}
 
-	// TODO: Expose metrics port after SDK uses controller-runtime's dynamic client
-	// sdk.ExposeMetricsPort()
-
 	// Get a config to talk to the apiserver
 	cfg, err := config.GetConfig()
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -67,9 +67,6 @@ func main() {`
`67`	`67`	`log.Fatalf("failed to get watch namespace: %v", err)`
`68`	`68`	`}`
`69`	`69`
`70`		`- // TODO: Expose metrics port after SDK uses controller-runtime's dynamic client`
`71`		`- // sdk.ExposeMetricsPort()`
`72`		`-`
`73`	`70`	`// Get a config to talk to the apiserver`
`74`	`71`	`cfg, err := config.GetConfig()`
`75`	`72`	`if err != nil {`
Original file line number	Diff line number	Diff line change
`@@ -63,9 +63,6 @@ func main() {`
`63`	`63`	`log.Fatalf("failed to get watch namespace: %v", err)`
`64`	`64`	`}`
`65`	`65`
`66`		`- // TODO: Expose metrics port after SDK uses controller-runtime's dynamic client`
`67`		`- // sdk.ExposeMetricsPort()`
`68`		`-`
`69`	`66`	`// Get a config to talk to the apiserver`
`70`	`67`	`cfg, err := config.GetConfig()`
`71`	`68`	`if err != nil {`