pkg/test/main_entry.go: build local binary instead of go run (#1089)

* pkg/test/main_entry.go: build local binary instead of `go run`

This allows us to kill the process on exti correctly, which
wouldn't always work correctly when using `go run`

Author: AlexNPavel

CHANGELOG.md

@@ -10,6 +10,8 @@
 
 ### Bug Fixes
 
+- Fix issue where running `operator-sdk test local --up-local` would sometimes leave a running process in the background after exit ([#1089](https://github.com/operator-framework/operator-sdk/pull/1020))
+
 ## v0.5.0
 
 ### Added

pkg/test/main_entry.go

@@ -28,6 +28,7 @@ import (
 
 	"k8s.io/client-go/tools/clientcmd"
 
+	"github.com/operator-framework/operator-sdk/internal/util/projutil"
 	"github.com/operator-framework/operator-sdk/pkg/k8sutil"
 	"github.com/operator-framework/operator-sdk/pkg/scaffold"
 	log "github.com/sirupsen/logrus"
@@ -63,10 +64,17 @@ func MainEntry(m *testing.M) {
 	var localCmd *exec.Cmd
 	var localCmdOutBuf, localCmdErrBuf bytes.Buffer
 	if *localOperator {
-		// TODO: make a generic 'up-local' function to deduplicate shared code between this and cmd/up/local
-		// taken from commands/operator-sdk/cmd/up/local.go
-		runArgs := append([]string{"run"}, []string{filepath.Join(scaffold.ManagerDir, scaffold.CmdFile)}...)
-		localCmd = exec.Command("go", runArgs...)
+		absProjectPath := projutil.MustGetwd()
+		projectName := filepath.Base(absProjectPath)
+		outputBinName := filepath.Join(scaffold.BuildBinDir, projectName+"-local")
+		args := []string{"build", "-o", outputBinName}
+		args = append(args, filepath.Join(scaffold.ManagerDir, scaffold.CmdFile))
+		bc := exec.Command("go", args...)
+		if err := projutil.ExecCmd(bc); err != nil {
+			log.Fatalf("Failed to build local operator binary: %s", err)
+		}
+
+		localCmd = exec.Command(outputBinName, args...)
 		localCmd.Stdout = &localCmdOutBuf
 		localCmd.Stderr = &localCmdErrBuf
 		c := make(chan os.Signal)