pkg/ansible: fail early if we are unable to find role or playbook (#677)

**Description of the change:**
Check that the absolute path to the playbook or role does exist.

**Motivation for the change:**
Not exposing errors to the user when we are unable to find the playbook or role makes it hard to figure out there is a problem when running.

Author: Shawn Hurley

.gitignore

@@ -102,3 +102,6 @@ tags
 # Build artifacts
 build/*
 test/ansible-operator/ansible-operator
+
+# Test artifacts
+pkg/ansible/runner/testdata/valid.yaml

pkg/ansible/runner/runner.go

@@ -123,6 +123,9 @@ func NewForPlaybook(path string, gvk schema.GroupVersionKind, finalizer *Finaliz
 	if !filepath.IsAbs(path) {
 		return nil, fmt.Errorf("playbook path must be absolute for %v", gvk)
 	}
+	if _, err := os.Stat(path); err != nil {
+		return nil, fmt.Errorf("playbook: %v was not found for %v", path, gvk)
+	}
 	r := &runner{
 		Path: path,
 		GVK:  gvk,
@@ -143,6 +146,9 @@ func NewForRole(path string, gvk schema.GroupVersionKind, finalizer *Finalizer,
 	if !filepath.IsAbs(path) {
 		return nil, fmt.Errorf("role path must be absolute for %v", gvk)
 	}
+	if _, err := os.Stat(path); err != nil {
+		return nil, fmt.Errorf("role path: %v was not found for %v", path, gvk)
+	}
 	path = strings.TrimRight(path, "/")
 	r := &runner{
 		Path: path,

pkg/ansible/runner/runner_test.go

@@ -15,6 +15,9 @@
 package runner
 
 import (
+	"html/template"
+	"os"
+	"path/filepath"
 	"reflect"
 	"testing"
 	"time"
@@ -23,6 +26,33 @@ import (
 )
 
 func TestNewFromWatches(t *testing.T) {
+	cwd, err := os.Getwd()
+	if err != nil {
+		t.Fatalf("unable to get working director: %v", err)
+	}
+
+	validTemplate := struct {
+		ValidPlaybook string
+		ValidRole     string
+	}{
+
+		ValidPlaybook: filepath.Join(cwd, "testdata", "playbook.yml"),
+		ValidRole:     filepath.Join(cwd, "testdata", "roles", "role"),
+	}
+
+	tmpl, err := template.ParseFiles("testdata/valid.yaml.tmpl")
+	if err != nil {
+	}
+	f, err := os.Create("testdata/valid.yaml")
+	if err != nil {
+		t.Fatalf("unable to create valid.yaml: %v", err)
+	}
+	err = tmpl.Execute(f, validTemplate)
+	if err != nil {
+		t.Fatalf("unable to create valid.yaml: %v", err)
+		return
+	}
+
 	testCases := []struct {
 		name        string
 		path        string
@@ -83,7 +113,7 @@ func TestNewFromWatches(t *testing.T) {
 						Group:   "app.example.com",
 						Kind:    "NoFinalizer",
 					},
-					Path:            "/opt/ansible/playbook.yaml",
+					Path:            validTemplate.ValidPlaybook,
 					reconcilePeriod: time.Second * 2,
 				},
 				schema.GroupVersionKind{
@@ -96,10 +126,10 @@ func TestNewFromWatches(t *testing.T) {
 						Group:   "app.example.com",
 						Kind:    "Playbook",
 					},
-					Path: "/opt/ansible/playbook.yaml",
+					Path: validTemplate.ValidPlaybook,
 					Finalizer: &Finalizer{
 						Name: "finalizer.app.example.com",
-						Role: "/opt/ansible/role",
+						Role: validTemplate.ValidRole,
 						Vars: map[string]interface{}{"sentinel": "finalizer_running"},
 					},
 				},
@@ -113,10 +143,10 @@ func TestNewFromWatches(t *testing.T) {
 						Group:   "app.example.com",
 						Kind:    "Role",
 					},
-					Path: "/opt/ansible/role",
+					Path: validTemplate.ValidRole,
 					Finalizer: &Finalizer{
 						Name:     "finalizer.app.example.com",
-						Playbook: "/opt/ansible/playbook.yaml",
+						Playbook: validTemplate.ValidPlaybook,
 						Vars:     map[string]interface{}{"sentinel": "finalizer_running"},
 					},
 				},

pkg/ansible/runner/testdata/playbook.yml

@@ -2,23 +2,23 @@
 - version: v1alpha1
   group: app.example.com
   kind: NoFinalizer
-  playbook: /opt/ansible/playbook.yaml
+  playbook: {{ .ValidPlaybook }}
   reconcilePeriod: 2s
 - version: v1alpha1
   group: app.example.com
   kind: Playbook
-  playbook: /opt/ansible/playbook.yaml
+  playbook: {{ .ValidPlaybook }}
   finalizer:
     name: finalizer.app.example.com
-    role: /opt/ansible/role
+    role: {{ .ValidRole }}
     vars:
       sentinel: finalizer_running
 - version: v1alpha1
   group: app.example.com
   kind: Role
-  role: /opt/ansible/role
+  role: {{ .ValidRole }}
   finalizer:
     name: finalizer.app.example.com
-    playbook: /opt/ansible/playbook.yaml
+    playbook: {{ .ValidPlaybook }}
     vars:
       sentinel: finalizer_running