-
Notifications
You must be signed in to change notification settings - Fork 226
Description
We could categorize controller into two groups, when they use finalizers and when they don't. The framework now handles these cases intelligently. Like we add finalizers, and trigger the cleanup
funtion when needed. Howeever there are cases whis not possible to cover with the current approach:
- What if user maintains an expicit in memory caches, that wan't to cleanup when on delete event. But don't want to use finalizers. We don't propagate now the delete event to the reconiler, that makes this impossible.
- What if some of the custom resources requires finalizers but others don't. The frameworks should be generic enough to handle such use cases.
- Others we might just not see, like react on changes that has been done if we removed our finalizer but other are still there.
So for sake of completeness would like to an option to not manage finalizer, and propagate all the events to reconciler.
This might be a flag to propagateAllEvents=true/false
This way framework will be as generic as controller-runtime
If cleaner is implemented, the cleanup
method will be called from the point that the resource is marked for deletion, and for delete event. If not reconcile method is called in all cases, on every event (including delete). - but this is up to discussion if we want to support that.