libprotobuf-c1 required after upgrading

[ffaraone]

Hi,

After upgrading from 1.3.1 to 1.4.1 in my Debian box, I'm getting the error: OSError: libprotobuf-c.so.1: cannot open shared object file: No such file or directory.

Installing libprotobuf-c1 fixes the issue.

Should it be statically linked into libziti.so?

Is it related to openziti/ziti-sdk-c#917 ?

Thanks!

[scareything]

Hello and thanks for pointing this out. Yeah, it seems like using builder-v3 is the first-order cause of this new dependency since builder-v3 installs the libprotobuf-c-dev package before ziti-sdk-c is built. Looking at the workflow logs for ziti-sdk-c it seems that the dependency was actually added in openziti/ziti-sdk-c#915 (which also changed the version of ziti-builder to v3).

The presence of a libprotobuf-c package on the build system shouldn't influence the actual dependencies of the built library since the build uses vcpkg to manage dependencies, and we aren't telling vcpkg to use the system's libprotobuf-c library (as we now do with the openssl library). So this is definitely not expected. I created openziti/ziti-sdk-c#929 to track this.