Skip to content

Commit 40a6209

Browse files
removes invalid openssl check and bumps deps (#217)
Signed-off-by: Adrian Cole <adrian@tetrate.io>
1 parent 1082720 commit 40a6209

File tree

11 files changed

+21
-36
lines changed

11 files changed

+21
-36
lines changed

build-bin/docker-compose-zipkin-gcp.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@ volumes:
33
gcp-service-account:
44
services:
55
extract-service-account:
6-
image: ghcr.io/openzipkin/alpine:3.19.0
6+
image: ghcr.io/openzipkin/alpine:3.19.1
77
volumes:
88
- gcp-service-account:/credentials:rw
99
command: -c 'echo $GOOGLE_APPLICATION_CREDENTIALS_BASE64 | base64 -d > /credentials/service-account-key.json'
1010
environment:
1111
- GOOGLE_APPLICATION_CREDENTIALS_BASE64
1212
show-service-account:
13-
image: ghcr.io/openzipkin/alpine:3.19.0
13+
image: ghcr.io/openzipkin/alpine:3.19.1
1414
volumes:
1515
- gcp-service-account:/credentials:ro
1616
# Show that the file exists as a sanity check in logs.

docker/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
#
1414

1515
# zipkin version should match zipkin.version in /pom.xml
16-
ARG zipkin_version=3.0.5
16+
ARG zipkin_version=3.0.6
1717

1818
# java_version is used during the installation process to build or download the module jar.
1919
#

encoder-stackdriver-brave/src/main/java/zipkin2/reporter/stackdriver/brave/AttributesExtractor.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,12 @@
1616
import brave.Span;
1717
import brave.Tag;
1818
import brave.handler.MutableSpan;
19-
import com.google.common.net.HostAndPort;
2019
import com.google.common.net.InetAddresses;
2120
import com.google.devtools.cloudtrace.v2.AttributeValue;
2221
import com.google.devtools.cloudtrace.v2.Span.Attributes;
2322
import java.net.Inet4Address;
2423
import java.net.Inet6Address;
2524
import java.net.InetAddress;
26-
import java.net.InetSocketAddress;
2725
import java.util.Map;
2826

2927
import static zipkin2.reporter.stackdriver.brave.SpanUtil.toTruncatableString;

encoder-stackdriver-brave/src/test/java/zipkin2/reporter/stackdriver/brave/SpanTranslatorTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222

2323
import static org.assertj.core.api.Assertions.assertThat;
2424
import static zipkin2.reporter.stackdriver.brave.AttributesExtractor.toAttributeValue;
25-
import static zipkin2.reporter.stackdriver.brave.SpanTranslator.createTimestamp;
2625
import static zipkin2.reporter.stackdriver.brave.SpanUtil.toTruncatableString;
2726
import static zipkin2.reporter.stackdriver.brave.TestObjects.clientSpan;
2827

module/src/main/java/zipkin/module/storage/stackdriver/ZipkinStackdriverStorageModule.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import com.linecorp.armeria.common.HttpMethod;
2626
import com.linecorp.armeria.common.RequestHeaders;
2727
import com.linecorp.armeria.common.logging.LogLevel;
28-
import io.netty.handler.ssl.OpenSsl;
2928
import java.io.IOException;
3029
import java.util.Collections;
3130
import org.springframework.beans.factory.annotation.Autowired;
@@ -94,11 +93,6 @@ StorageComponent storage(
9493
ClientFactory clientFactory,
9594
ZipkinStackdriverStorageProperties properties,
9695
Credentials credentials) {
97-
if (!OpenSsl.isAvailable()) {
98-
throw new IllegalStateException(
99-
"OpenSsl is required. This usually requires netty-tcnative-boringssl-static");
100-
}
101-
10296
ClientOptionsBuilder options = ClientOptions.builder();
10397

10498
HttpLogging httpLogging = properties.getHttpLogging();

module/src/test/java/zipkin2/storage/stackdriver/ZipkinStackdriverStorageIntegrationTest.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2016-2023 The OpenZipkin Authors
2+
* Copyright 2016-2024 The OpenZipkin Authors
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
55
* in compliance with the License. You may obtain a copy of the License at
@@ -30,12 +30,10 @@
3030
import java.util.stream.Collectors;
3131
import java.util.stream.LongStream;
3232
import org.junit.jupiter.api.AfterEach;
33-
import org.junit.jupiter.api.BeforeEach;
3433
import org.junit.jupiter.api.Order;
3534
import org.junit.jupiter.api.Test;
3635
import org.junit.jupiter.api.TestInstance;
3736
import org.junit.jupiter.api.extension.BeforeAllCallback;
38-
import org.junit.jupiter.api.extension.BeforeTestExecutionCallback;
3937
import org.junit.jupiter.api.extension.ExtensionContext;
4038
import org.junit.jupiter.api.extension.RegisterExtension;
4139
import org.springframework.boot.autoconfigure.context.PropertyPlaceholderAutoConfiguration;

pom.xml

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,12 @@
7474
<!-- matching armeria/grpc/zipkin -->
7575
<zipkin.groupId>io.zipkin.zipkin2</zipkin.groupId>
7676
<!-- when updating, update docker/Dockerfile and storage/src/test/java/zipkin2/storage/kafka/IT* -->
77-
<zipkin.version>3.0.5</zipkin.version>
78-
<zipkin-reporter.version>3.2.1</zipkin-reporter.version>
77+
<zipkin.version>3.0.6</zipkin.version>
78+
<zipkin-reporter.version>3.3.0</zipkin-reporter.version>
7979
<spring-boot.version>3.2.2</spring-boot.version>
8080
<!-- armeria.groupId allows you to test feature branches with jitpack -->
8181
<armeria.groupId>com.linecorp.armeria</armeria.groupId>
82-
<armeria.version>1.26.4</armeria.version>
82+
<armeria.version>1.27.1</armeria.version>
8383
<log4j.version>2.21.1</log4j.version>
8484

8585
<!-- This allows you to test feature branches with jitpack -->
@@ -89,29 +89,29 @@
8989
<brave.version>6.0.0</brave.version>
9090

9191
<!-- from armeria-grpc or grpc-google-cloud-trace-v1 whichever is higher -->
92-
<grpc.version>1.60.0</grpc.version>
92+
<grpc.version>1.61.1</grpc.version>
9393
<!-- from grpc-protobuf -->
94-
<protobuf.version>3.24.0</protobuf.version>
95-
<guava.version>32.0.1-android</guava.version>
94+
<protobuf.version>3.25.1</protobuf.version>
95+
<guava.version>32.1.3</guava.version>
9696

9797
<!-- stackdriver deps -->
98-
<google-auth-library-oauth2-http.version>1.22.0</google-auth-library-oauth2-http.version>
99-
<proto-google-common-protos.version>2.31.0</proto-google-common-protos.version>
98+
<google-auth-library-oauth2-http.version>1.23.0</google-auth-library-oauth2-http.version>
99+
<proto-google-common-protos.version>2.34.0</proto-google-common-protos.version>
100100
<!-- only used for stackdriver protos, we could possibly obviate this if a problem -->
101-
<grpc-google-cloud-trace.version>2.34.0</grpc-google-cloud-trace.version>
101+
<grpc-google-cloud-trace.version>2.35.0</grpc-google-cloud-trace.version>
102102

103103
<!-- pubsub deps -->
104-
<google-cloud-pubsub.version>1.126.0</google-cloud-pubsub.version>
105-
<grpc-google-cloud-pubsub-v1.version>1.108.0</grpc-google-cloud-pubsub-v1.version>
104+
<google-cloud-pubsub.version>1.126.6</google-cloud-pubsub.version>
105+
<grpc-google-cloud-pubsub-v1.version>1.108.6</grpc-google-cloud-pubsub-v1.version>
106106

107-
<assertj.version>3.25.1</assertj.version>
107+
<assertj.version>3.25.3</assertj.version>
108108
<awaitility.version>4.2.0</awaitility.version>
109-
<junit-jupiter.version>5.10.1</junit-jupiter.version>
110-
<mockito.version>5.9.0</mockito.version>
109+
<junit-jupiter.version>5.10.2</junit-jupiter.version>
110+
<mockito.version>5.10.0</mockito.version>
111111

112112
<!-- override to set exclusions per-project -->
113113
<errorprone.args />
114-
<errorprone.version>2.24.1</errorprone.version>
114+
<errorprone.version>2.25.0</errorprone.version>
115115
<auto-value.version>1.10.4</auto-value.version>
116116

117117
<license.skip>${skipTests}</license.skip>

propagation-stackdriver/src/test/java/brave/propagation/stackdriver/XCloudTraceContextExtractorTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2016-2023 The OpenZipkin Authors
2+
* Copyright 2016-2024 The OpenZipkin Authors
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
55
* in compliance with the License. You may obtain a copy of the License at
@@ -14,7 +14,6 @@
1414
package brave.propagation.stackdriver;
1515

1616
import brave.propagation.B3Propagation;
17-
import brave.propagation.Propagation;
1817
import brave.propagation.TraceContextOrSamplingFlags;
1918
import org.junit.jupiter.api.Test;
2019

sender-pubsub/src/test/java/zipkin2/reporter/pubsub/PubSubSenderTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import com.google.cloud.pubsub.v1.stub.GrpcPublisherStub;
2929
import com.google.cloud.pubsub.v1.stub.PublisherStub;
3030
import com.google.cloud.pubsub.v1.stub.PublisherStubSettings;
31-
import com.google.pubsub.v1.GetTopicRequest;
3231
import com.google.pubsub.v1.PublishRequest;
3332
import com.google.pubsub.v1.PublishResponse;
3433
import com.google.pubsub.v1.PublisherGrpc;

sender-stackdriver/src/test/java/zipkin2/reporter/stackdriver/AsyncReporterStackdriverSenderTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
import static org.assertj.core.api.Assertions.assertThat;
4242
import static org.mockito.ArgumentMatchers.any;
4343
import static org.mockito.Mockito.doAnswer;
44-
import static org.mockito.Mockito.never;
4544
import static org.mockito.Mockito.spy;
4645
import static org.mockito.Mockito.verify;
4746

translation-stackdriver/src/test/java/zipkin2/translation/stackdriver/SpanTranslatorTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2016-2023 The OpenZipkin Authors
2+
* Copyright 2016-2024 The OpenZipkin Authors
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
55
* in compliance with the License. You may obtain a copy of the License at
@@ -15,7 +15,6 @@
1515

1616
import com.google.protobuf.Timestamp;
1717
import java.util.ArrayList;
18-
import java.util.Arrays;
1918
import java.util.List;
2019
import org.junit.jupiter.api.Test;
2120
import zipkin2.Endpoint;

0 commit comments

Comments
 (0)