Skip to content

Commit 325ac65

Browse files
authored
Disable attribute testing for non-HTML element attributes (#1638)
1 parent 604f347 commit 325ac65

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

test-builder/elements.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,8 @@ const build = async (specElements, customElements) => {
167167
}
168168

169169
// Add tests for the attributes
170-
if (data.attributes) {
170+
// XXX attribute tests for SVG and MathML disabled, need to determine how to properly test them
171+
if (data.attributes && category === "html") {
171172
for (const [attrName, attrProp] of data.attributes.entries() as [
172173
string,
173174
string,

views/index.ejs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,7 @@ See the LICENSE file for copyright details
7373
<li>Detection for features under alternative names are not yet supported</li>
7474
<li>Some browser extensions, such as password managers, may cause compatibility conflicts</li>
7575
<li>CSS property value detection may produce false positives for certain properties</li>
76-
<li>Many tests for SVG attributes are improper due to not having API counterparts, resulting in no support reported</li>
77-
<li>Tests for MathML element attributes are not yet implemented</li>
76+
<li>Tests for SVG and MathML element attributes are not yet implemented</li>
7877
</ul>
7978

8079
<p id="known-caveats-file-issue">If you find any errors in feature detection, please <a href="https://github.com/openwebdocs/mdn-bcd-collector/issues/new"><span class="mdi mdi-alert-circle-outline"></span> file an issue</a> in the GitHub repository.</p>

0 commit comments

Comments
 (0)