fix: mock issues in tests

Signed-off-by: Daniel Bluhm <dbluhm@pm.me>

Author: dbluhm

aries_cloudagent/protocols/endorse_transaction/v1_0/handlers/tests/test_transaction_job_to_send_handler.py

@@ -26,7 +26,7 @@ async def test_called(self):
             await handler.handle(request_context, responder)
 
         mock_tran_mgr.return_value.set_transaction_their_job.assert_called_once_with(
-            request_context.message, request_context.message_receipt
+            request_context.message, request_context.connection_record
         )
         assert not responder.messages
 
@@ -48,6 +48,6 @@ async def test_called_x(self):
             await handler.handle(request_context, responder)
 
         mock_tran_mgr.return_value.set_transaction_their_job.assert_called_once_with(
-            request_context.message, request_context.message_receipt
+            request_context.message, request_context.connection_record
         )
         assert not responder.messages

aries_cloudagent/protocols/endorse_transaction/v1_0/handlers/transaction_job_to_send_handler.py

@@ -26,9 +26,12 @@ async def handle(self, context: RequestContext, responder: BaseResponder):
 
         if not context.connection_ready:
             raise HandlerException("No connection established")
+        assert context.connection_record
 
         mgr = TransactionManager(context.profile)
         try:
-            await mgr.set_transaction_their_job(context.message, context.message_receipt)
+            await mgr.set_transaction_their_job(
+                context.message, context.connection_record
+            )
         except TransactionManagerError:
             self._logger.exception("Error receiving transaction jobs")

aries_cloudagent/protocols/endorse_transaction/v1_0/tests/test_manager.py

@@ -12,7 +12,6 @@
 from .....cache.in_memory import InMemoryCache
 from .....connections.models.conn_record import ConnRecord
 from .....ledger.base import BaseLedger
-from .....storage.error import StorageNotFoundError
 from .....tests import mock
 from .....wallet.base import BaseWallet
 from .....wallet.did_method import SOV, DIDMethods
@@ -804,34 +803,16 @@ async def test_set_transaction_my_job(self):
     async def test_set_transaction_their_job(self):
         mock_job = mock.MagicMock()
         mock_conn = mock.MagicMock()
+        mock_conn.metadata_get = mock.CoroutineMock(
+            side_effect=[
+                None,
+                {"meta": "data"},
+            ]
+        )
+        mock_conn.metadata_set = mock.CoroutineMock()
 
-        with mock.patch.object(
-            ConnRecord, "retrieve_by_did", mock.CoroutineMock()
-        ) as mock_retrieve:
-            mock_retrieve.return_value = mock.MagicMock(
-                metadata_get=mock.CoroutineMock(
-                    side_effect=[
-                        None,
-                        {"meta": "data"},
-                    ]
-                ),
-                metadata_set=mock.CoroutineMock(),
-            )
-
-            for i in range(2):
-                await self.manager.set_transaction_their_job(mock_job, mock_conn)
-
-    async def test_set_transaction_their_job_conn_not_found(self):
-        mock_job = mock.MagicMock()
-        mock_conn = mock.MagicMock()
-
-        with mock.patch.object(
-            ConnRecord, "retrieve_by_did", mock.CoroutineMock()
-        ) as mock_retrieve:
-            mock_retrieve.side_effect = StorageNotFoundError()
-
-            with self.assertRaises(TransactionManagerError):
-                await self.manager.set_transaction_their_job(mock_job, mock_conn)
+        for i in range(2):
+            await self.manager.set_transaction_their_job(mock_job, mock_conn)
 
     @mock.patch.object(AnonCredsIssuer, "finish_schema")
     @mock.patch.object(AnonCredsIssuer, "finish_cred_def")