Correct subset creation and evaluation (#3978)

* Fix kaldi subset creation convert.py

* FIx coco_orig_metrics.py for subset evaluation

* Update dataset.py

Author: pwolnows

tools/accuracy_checker/accuracy_checker/annotation_converters/convert.py

@@ -248,7 +248,7 @@ def make_subset_kaldi(annotation, size, shuffle=True, **kwargs):
                 indices = indices[:num_elem_to_add]
         else:
             if shuffle:
-                indices = np.random.shuffle(indices)
+                np.random.shuffle(indices)
         subset.extend([annotation[idx] for idx in indices])
         if len(subset) == size:
             break

tools/accuracy_checker/accuracy_checker/dataset.py

@@ -389,6 +389,10 @@ def multi_infer(self):
     def labels(self):
         return self.data_provider.labels
 
+    @property
+    def subsample_size(self):
+        return get_subsample_size(self.config)
+
 
 def read_annotation(annotation_file: Path, log=True):
     annotation_file = Path(annotation_file)

tools/accuracy_checker/accuracy_checker/metrics/coco_orig_metrics.py

@@ -381,8 +381,7 @@ def _run_coco_evaluation(coco, coco_res, iou_type='bbox', threshold=None):
 
     @property
     def _use_original_coco(self):
-        subsample_size = self.dataset.config.get('subsample_size')
-        if not subsample_size:
+        if not self.dataset.subsample_size:
             annotation_conversion_parameters = self.dataset.config.get('annotation_conversion', {})
             if 'annotation_file' in annotation_conversion_parameters:
                 annotation_file = Path(annotation_conversion_parameters['annotation_file'])