Skip to content

Commit ae00215

Browse files
committed
minor clean up
1 parent 9d259e4 commit ae00215

File tree

2 files changed

+2
-34
lines changed

2 files changed

+2
-34
lines changed

src/main/java/com/opentok/OpenTok.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,13 +154,13 @@ public String generateToken(String sessionId, TokenOptions tokenOptions) throws
154154
if (!sessionIdParts.contains(Integer.toString(this.apiKey))) {
155155
throw new InvalidArgumentException("Session ID was not valid");
156156
}
157-
157+
158+
// NOTE: kind of wasteful of a Session instance
158159
Session session = new Session(sessionId, apiKey, apiSecret);
159160
return session.generateToken(tokenOptions);
160161
}
161162

162163
public String generateToken(String sessionId) throws OpenTokException {
163-
// NOTE: should there be a static defaultTokenOptions?
164164
return generateToken(sessionId, new TokenOptions.Builder().build());
165165
}
166166

src/test/java/com/opentok/test/OpenTokTest.java

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -343,37 +343,5 @@ public void testTokenBadSessionId() throws OpenTokException {
343343
assertEquals(InvalidArgumentException.class, e.getClass());
344344
}
345345
}
346-
// @Test
347-
// public void testTokenNullSessionId() throws OpenTokException {
348-
// OpenTokException expected = null;
349-
// try {
350-
// sdk.generateToken(null);
351-
// } catch (OpenTokException e) {
352-
// expected = e;
353-
// }
354-
// Assert.assertNotNull("Java SDK tests: exception should be thrown for null sessionId", expected);
355-
// }
356-
//
357-
//
358-
// public void testTokenEmptySessionId() throws OpenTokException {
359-
// OpenTokException expected = null;
360-
// try {
361-
// sdk.generateToken("");
362-
// } catch (OpenTokException e) {
363-
// expected = e;
364-
// }
365-
// Assert.assertNotNull("Java SDK tests: exception should be thrown for empty sessionId", expected);
366-
// }
367-
//
368-
// @Test
369-
// public void testTokenIncompleteSessionId() throws OpenTokException {
370-
// OpenTokException expected = null;
371-
// try {
372-
// sdk.generateToken("jkasjda2ndasd");
373-
// } catch (OpenTokException e) {
374-
// expected = e;
375-
// }
376-
// Assert.assertNotNull("Java SDK tests: exception should be thrown for invalid sessionId", expected);
377-
// }
378346

379347
}

0 commit comments

Comments
 (0)