fix: Expose server message in 400 responses (#264)

* Bump version: v4.14.0 → v4.14.1

* Bump dependency versions

* Expose error message detail for 400 responses

* Update CI job name

* Re-add 408 response handling

Author: SMadani

.bumpversion.cfg

@@ -1,7 +1,7 @@
 [bumpversion]
 commit = True
 tag = False
-current_version = v4.14.0
+current_version = v4.14.1
 parse = (?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)(\-(?P<release>[a-z]+)(?P<build>\d+))?
 serialize = 
 	{major}.{minor}.{patch}-{release}{build}

.github/workflows/build.yml

@@ -1,4 +1,4 @@
-name: Build Java CI
+name: Build & Test
 on:
   push:
     branches:
@@ -81,4 +81,4 @@ jobs:
         run: ./gradlew build
 
       - name: Run Codecov
-        uses: codecov/codecov-action@v3
+        uses: codecov/codecov-action@v4

README.md

@@ -45,7 +45,7 @@ When you use Maven as your build tool, you can manage dependencies in the `pom.x
 <dependency>
     <groupId>com.tokbox</groupId>
     <artifactId>opentok-server-sdk</artifactId>
-    <version>4.14.0</version>
+    <version>4.14.1</version>
 </dependency>
 ```
 
@@ -55,7 +55,7 @@ When you use Gradle as your build tool, you can manage dependencies in the `buil
 
 ```groovy
 dependencies {
-  compile group: 'com.tokbox', name: 'opentok-server-sdk', version: '4.14.0'
+  compile group: 'com.tokbox', name: 'opentok-server-sdk', version: '4.14.1'
 }
 ```
 

build.gradle

@@ -11,7 +11,7 @@ plugins {
 
 group = 'com.tokbox'
 archivesBaseName = 'opentok-server-sdk'
-version = '4.14.0'
+version = '4.14.1'
 
 ext.githubPath = "opentok/$archivesBaseName"
 
@@ -21,15 +21,13 @@ repositories {
 
 dependencies {
     testImplementation 'junit:junit:4.13.2'
-    testImplementation 'org.wiremock:wiremock:3.5.4'
-    testImplementation 'org.xmlunit:xmlunit-core:2.10.0'
-    testImplementation 'net.minidev:json-smart:2.5.1'
-    testImplementation 'com.google.guava:guava:33.2.0-jre'
+    testImplementation 'org.wiremock:wiremock:3.6.0'
+    testImplementation 'com.google.guava:guava:33.2.1-jre'
 
     implementation 'commons-lang:commons-lang:2.6'
     implementation 'commons-codec:commons-codec:1.17.0'
-    implementation 'io.netty:netty-codec-http:4.1.109.Final'
-    implementation 'io.netty:netty-handler:4.1.109.Final'
+    implementation 'io.netty:netty-codec-http:4.1.111.Final'
+    implementation 'io.netty:netty-handler:4.1.111.Final'
     implementation 'org.asynchttpclient:async-http-client:2.12.3'
     implementation 'com.fasterxml.jackson.core:jackson-databind:2.17.1'
     implementation 'org.bitbucket.b_c:jose4j:0.9.6'

src/main/java/com/opentok/constants/Version.java

@@ -8,5 +8,5 @@
 package com.opentok.constants;
 
 public class Version {
-    public static final String VERSION = "4.14.0";
+    public static final String VERSION = "4.14.1";
 }

src/main/java/com/opentok/util/HttpClient.java

@@ -2720,8 +2720,15 @@ public void testConnectAudioStreamErrors() throws OpenTokException {
         String uri = "ws://service.com/wsendpoint";
         AudioConnectorProperties connectProperties = new AudioConnectorProperties.Builder(uri).build();
 
-        stubFor(post(urlEqualTo(url)).willReturn(aResponse().withStatus(400)));
-        assertThrows(RequestException.class, () -> sdk.connectAudioStream(sessionId, apiSecret, connectProperties));
+        String expected400Msg = "Oops! Something went wrong - bad request.";
+        stubFor(post(urlEqualTo(url)).willReturn(aResponse().withStatus(400).withBody(expected400Msg)));
+        try {
+            AudioConnector parsed = sdk.connectAudioStream(sessionId, apiSecret, connectProperties);
+            fail("Expected RequestException, but got "+parsed);
+        }
+        catch (RequestException ex) {
+            assertEquals(expected400Msg, ex.getMessage());
+        }
 
         stubFor(post(urlEqualTo(url)).willReturn(aResponse().withStatus(403)));
         assertThrows(RequestException.class, () -> sdk.connectAudioStream(sessionId, apiSecret, connectProperties));