Skip to content

Commit 628014d

Browse files
committed
Merge review changes (Squash)
1 parent 09f5f22 commit 628014d

5 files changed

+14
-14
lines changed

modules/network-observability-filtering-ebpf-rule.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ You can configure the `FlowCollector` custom resource to filter eBPF flows using
88

99
[IMPORTANT]
1010
====
11-
* You cannot use duplicate CIDRs in filter rules.
11+
* You cannot use duplicate Classless Inter-Domain Routing (CIDRs) in filter rules.
1212
* When an IP address matches multiple filter rules, the rule with the most specific CIDR prefix (longest prefix) takes precedence.
1313
====
1414

modules/network-observability-netobserv-cli-reference.adoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ $ oc netobserv flows [<feature_option>] [<command_options>]
8686
|--port| filter port | –
8787
|--ports| filter on either of two ports | –
8888
|--protocol| filter protocol | –
89-
|--query| filter flows using a custom query | –
89+
|--query| filter flows by using a custom query | –
9090
|--sport_range| filter source port range | –
9191
|--sport| filter source port | –
9292
|--sports| filter on either of two source ports | –
@@ -134,7 +134,7 @@ $ oc netobserv packets [<option>]
134134
|--port| filter port | –
135135
|--ports| filter on either of two ports | –
136136
|--protocol| filter protocol | –
137-
|--query| filter flows using a custom query | –
137+
|--query| filter flows by using a custom query | –
138138
|--sport_range| filter source port range | –
139139
|--sport| filter source port | –
140140
|--sports| filter on either of two source ports | –
@@ -184,7 +184,7 @@ $ oc netobserv metrics [<option>]
184184
|--port| filter port | –
185185
|--ports| filter on either of two ports | –
186186
|--protocol| filter protocol | –
187-
|--query| filter flows using a custom query | –
187+
|--query| filter flows by using a custom query | –
188188
|--sport_range| filter source port range | –
189189
|--sport| filter source port | –
190190
|--sports| filter on either of two source ports | –

modules/proc_network-observability-working-with-ipsec.adoc renamed to modules/network-observability-proc_configuring-ipsec-with-flow-collector-resource.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
// network_observability/observing-network-traffic.adoc
44

55
:_mod-docs-content-type: PROCEDURE
6-
[id="network-observability-working-with-ipsec_{context}"]
7-
= Working with IPsec
6+
[id="network-observability-configuring-ipsec-with-flow-collector-resource_{context}"]
7+
= Configuring IPsec with the FlowCollector custom resource
88

99
In {product-title}, IPsec is disabled by default. You can enable IPsec by following the instructions in "Configuring IPsec encryption".
1010

modules/network-observability-viewing-network-events.adoc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ You can edit the `FlowCollector` to view information about network traffic event
1515
* `BaselineNetworkPolicy`
1616
* `EgressFirewall`
1717
* `UserDefinedNetwork` isolation
18-
* Multicast ACLs
18+
* Multicast ACLs
1919
2020
.Prerequisites
21-
* You must have `OVNObservability` enabled by setting the `TechPreviewNoUpgrade` feature set in the `FeatureGate` custom resource (CR) named `cluster`. For more information, see "Enabling feature sets using the CLI" and "Checking OVN-Kubernetes network traffic with OVS sampling using the CLI".
21+
* You must have `OVNObservability` enabled by setting the `TechPreviewNoUpgrade` feature set in the `FeatureGate` custom resource (CR) named `cluster`. For more information, see "Enabling feature sets using the CLI" and "Checking OVN-Kubernetes network traffic with OVS sampling using the CLI".
2222
* You have created at least one of the following network APIs: `NetworkPolicy`, `AdminNetworkPolicy`, `BaselineNetworkPolicy`, `UserDefinedNetwork` isolation, multicast, or `EgressFirewall`.
2323
2424
.Procedure
@@ -44,15 +44,15 @@ spec:
4444
features:
4545
- "NetworkEvents"
4646
----
47-
<1> Optional: The `sampling` parameter is set to a value of 1 so that all network events are captured. If sampling `1` is too resource heavy, set sampling to something more appropriate for your needs.
47+
<1> Optional: The `sampling` parameter is set to a value of 1 so that all network events are captured. If sampling `1` is too resource heavy, set sampling to something more appropriate for your needs.
4848
<2> The `privileged` parameter is set to `true` because the `OVN observability` library needs to access local Open vSwitch (OVS) socket and OpenShift Virtual Network (OVN) databases.
4949

5050
.Verification
51-
. Navigate to the *Network Traffic* view and select the *Traffic flows* table.
52-
. You should see the new column, *Network Events*, where you can view information about impacts of one of the following network APIs you have enabled: `NetworkPolicy`, `AdminNetworkPolicy`, `BaselineNetworkPolicy`, `UserDefinedNetwork` isolation, multicast, or egress firewalls.
51+
. Navigate to the *Network Traffic* view and select the *Traffic flows* table.
52+
. You should see the new column, *Network Events*, where you can view information about impacts of one of the following network APIs you have enabled: `NetworkPolicy`, `AdminNetworkPolicy`, `BaselineNetworkPolicy`, `UserDefinedNetwork` isolation, multicast, or egress firewalls.
5353

5454
An example of the kind of events you could see in this column is as follows:
55-
+
55+
5656
.Example of Network Events output
5757
[source,text]
5858
----

observability/network_observability/observing-network-traffic.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,11 @@ include::modules/network-observability-networking-events-overview.adoc[leveloffs
5858
include::modules/network-observability-trafficflow.adoc[leveloffset=+1]
5959
include::modules/network-observability-working-with-trafficflow.adoc[leveloffset=+2]
6060
include::modules/network-observability-configuring-options-trafficflow.adoc[leveloffset=+2]
61-
include::modules/proc_network-observability-working-with-ipsec.adoc[leveloffset=+2]
61+
include::modules/network-observability-proc_configuring-ipsec-with-flow-collector-resource.adoc[leveloffset=+2]
6262
6363
[role="_additional-resources"]
6464
.Additional resources
65-
*xref:../../networking/network_security/configuring-ipsec-ovn.adoc#configuring-ipsec-ovn[Configuring IPsec encryption]
65+
* xref:../../networking/network_security/configuring-ipsec-ovn.adoc#configuring-ipsec-ovn[Configuring IPsec encryption]
6666
6767
//Traffic flows continued
6868
include::modules/network-observability-working-with-conversations.adoc[leveloffset=+2]

0 commit comments

Comments
 (0)