Skip to content

Commit 4c72cdc

Browse files
authored
Merge pull request #91029 from subhtk/ocp53445
OCPBUGS#53445: Updated example for istio issuer
2 parents bcb1d8f + 773d2e2 commit 4c72cdc

File tree

2 files changed

+20
-17
lines changed

2 files changed

+20
-17
lines changed

modules/cert-manager-istio-creating-issuer.adoc

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,16 @@ Use this procedure to create the root CA issuer for Istio-CSR agent.
1313
Other supported issuers can be used, except for the ACME issuer, which is not supported. For more information, see "{cert-manager-operator} issuer providers".
1414
====
1515

16-
* Create a YAML file, for example, `issuer.yaml`, that defines the `Issuer` and `Certificate` objects:
16+
.Procedure
17+
18+
. Create a new project for installing Istio-CSR by running the following command. If you have an existing project for installing Istio-CSR, skip this step.
19+
+
20+
[source,terminal]
21+
----
22+
$ oc new-project <istio_csr_project_name>
23+
----
24+
25+
. Create a YAML file that defines the `Issuer` and `Certificate` objects:
1726
+
1827
.Example `issuer.yaml` file
1928
[source,yaml]
@@ -22,17 +31,17 @@ apiVersion: cert-manager.io/v1
2231
kind: Issuer <1>
2332
metadata:
2433
name: selfsigned
25-
namespace: <istio_project_name> <2>
34+
namespace: <istio_csr_project_name> <2>
2635
spec:
2736
selfSigned: {}
2837
---
2938
apiVersion: cert-manager.io/v1
3039
kind: Certificate
3140
metadata:
3241
name: istio-ca
33-
namespace: <istio_project_name>
42+
namespace: <istio_csr_project_name>
3443
spec:
35-
isCA: true
44+
isCA: true
3645
duration: 87600h # 10 years
3746
secretName: istio-ca
3847
commonName: istio-ca
@@ -48,10 +57,11 @@ spec:
4857
kind: Issuer <1>
4958
group: cert-manager.io
5059
---
51-
kind: Issuer
60+
apiVersion: cert-manager.io/v1
61+
kind: Issuer <1>
5262
metadata:
5363
name: istio-ca
54-
namespace: <istio_project_name> <2>
64+
namespace: <istio_csr_project_name> <2>
5565
spec:
5666
ca:
5767
secretName: istio-ca
@@ -65,7 +75,7 @@ spec:
6575
+
6676
[source,terminal]
6777
----
68-
$ oc get issuer istio-ca -n <istio_project_name>
78+
$ oc get issuer istio-ca -n <istio_csr_project_name>
6979
----
7080
+
7181
.Example output

modules/cert-manager-istio-csr-installing.adoc

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,6 @@ If you are using `Issuer` resource, create the `Issuer` and `Certificate` resour
2121
2222
.Procedure
2323

24-
. Create a new project for installing Istio-CSR by running the following command. You can use an existing project and skip this step.
25-
+
26-
[source,terminal]
27-
----
28-
$ oc new-project <istio_csr_project_name>
29-
----
30-
3124
. Create the `IstioCSR` custom resource to enable Istio-CSR agent managed by the {cert-manager-operator} for processing Istio workload and control plane certificate signing requests.
3225
+
3326
[NOTE]
@@ -40,9 +33,9 @@ Only one `IstioCSR` custom resource (CR) is supported at a time. If multiple `Is
4033
* The Operator does not automatically remove objects created for `IstioCSR`. If an active `IstioCSR` resource is deleted and a new one is created in a different namespace without removing the previous deployments, multiple `istio-csr` deployments may remain active. This behavior is not recommended and is not supported.
4134
====
4235
43-
.. Create a YAML file, for example, `istiocsr.yaml`, that defines the `IstioCSR` object:
36+
.. Create a YAML file that defines the `IstioCSR` object:
4437
+
45-
.Example `IstioCSR.yaml` file
38+
.Example `IstioCSR` CR
4639
[source,yaml]
4740
----
4841
apiVersion: operator.openshift.io/v1alpha1
@@ -51,7 +44,7 @@ metadata:
5144
name: default
5245
namespace: <istio_csr_project_name>
5346
spec:
54-
IstioCSRConfig:
47+
istioCSRConfig:
5548
certManager:
5649
issuerRef:
5750
name: istio-ca <1>

0 commit comments

Comments
 (0)