Skip to content

Commit 20229df

Browse files
committed
incorporating peer review feedback
1 parent 521f757 commit 20229df

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

hosted_control_planes/hcp-prepare/hcp-override-resource-util.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ include::_attributes/common-attributes.adoc[]
66

77
toc::[]
88

9-
The set of baseline measurements for resource utilization can vary in every hosted cluster.
9+
The set of baseline measurements for resource utilization can vary in each hosted cluster.
1010

1111
include::modules/hcp-override.adoc[leveloffset=+1]
1212
include::modules/hcp-disable-metrics.adoc[leveloffset=+1]

modules/hcp-disable-metrics.adoc

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@
66
[id="hcp-disable-metrics_{context}"]
77
= Disabling the metric service monitoring
88

9-
After enabling the `hypershift-addon` managed cluster addon, the metric service monitoring is configured by default so that {product-title} monitoring can gather metrics from `hypershift-addon`.
9+
After you enable the `hypershift-addon` managed cluster add-on, metric service monitoring is configured by default so that {product-title} monitoring can gather metrics from `hypershift-addon`.
1010

1111
.Procedure
1212

13-
You can disable the metric service monitoring by completing the following steps:
13+
You can disable metric service monitoring by completing the following steps:
1414

1515
. Log in to your hub cluster by running the following command:
1616
+
@@ -19,7 +19,7 @@ You can disable the metric service monitoring by completing the following steps:
1919
$ oc login
2020
----
2121

22-
. Open the `hypershift-addon-deploy-config` add-on deployment configuration specification for editing by running the following command:
22+
. Edit the `hypershift-addon-deploy-config` add-on deployment configuration specification by running the following command:
2323
+
2424
[source,terminal]
2525
----
@@ -45,6 +45,11 @@ spec:
4545
value: "true"
4646
----
4747
+
48-
<1> The `disableMetrics=true` customized variable disables the metric service monitoring configuration for both new and existing `hypershift-addon` managed cluster add-ons.
48+
<1> The `disableMetrics=true` customized variable disables metric service monitoring for both new and existing `hypershift-addon` managed cluster add-ons.
4949

50-
. Save the changes.
50+
. Apply the changes to the configuration specification by running the following command:
51+
+
52+
[source,terminal]
53+
----
54+
$ oc apply -f <filename>.yaml
55+
----

modules/hcp-override.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
[id="hcp-override_{context}"]
77
= Overriding resource utilization measurements for a hosted cluster
88

9-
You can override the resource utilization measurements based on the type and pace of your cluster workload. Complete the following steps:
9+
You can override resource utilization measurements based on the type and pace of your cluster workload.
1010

1111
.Procedure
1212

0 commit comments

Comments
 (0)