Skip to content

Commit 06600ac

Browse files
authored
Merge pull request #79344 from rh-max/srvls-ossm-labels
[SRVCOM-3149] Change sidecar injection from annotations to labels
2 parents 2e543df + 6ecadec commit 06600ac

File tree

2 files changed

+52
-26
lines changed

2 files changed

+52
-26
lines changed

modules/serverless-ossm-installing-and-configuring-openshift-serverless.adoc

Lines changed: 26 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,14 @@ spec:
2222
enabled: true <1>
2323
deployments: <2>
2424
- name: activator
25-
annotations:
25+
labels:
2626
"sidecar.istio.io/inject": "true"
27+
annotations:
2728
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
2829
- name: autoscaler
29-
annotations:
30+
labels:
3031
"sidecar.istio.io/inject": "true"
32+
annotations:
3133
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
3234
config:
3335
istio: <3>
@@ -61,20 +63,24 @@ spec:
6163
istio: enabled <1>
6264
workloads: <2>
6365
- name: pingsource-mt-adapter
64-
annotations:
66+
labels:
6567
"sidecar.istio.io/inject": "true"
68+
annotations:
6669
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
6770
- name: imc-dispatcher
68-
annotations:
71+
labels:
6972
"sidecar.istio.io/inject": "true"
73+
annotations:
7074
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
7175
- name: mt-broker-ingress
72-
annotations:
76+
labels:
7377
"sidecar.istio.io/inject": "true"
78+
annotations:
7479
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
7580
- name: mt-broker-filter
76-
annotations:
81+
labels:
7782
"sidecar.istio.io/inject": "true"
83+
annotations:
7884
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
7985
----
8086
<1> Enable Eventing Istio controller to create a `DestinationRule` for each `InMemoryChannel` or `KafkaChannel` service.
@@ -113,32 +119,39 @@ spec:
113119
enabled: true
114120
workloads: <2>
115121
- name: kafka-controller
116-
annotations:
122+
labels:
117123
"sidecar.istio.io/inject": "true"
124+
annotations:
118125
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
119126
- name: kafka-broker-receiver
120-
annotations:
127+
labels:
121128
"sidecar.istio.io/inject": "true"
129+
annotations:
122130
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
123131
- name: kafka-broker-dispatcher
124-
annotations:
132+
labels:
125133
"sidecar.istio.io/inject": "true"
134+
annotations:
126135
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
127136
- name: kafka-channel-receiver
128-
annotations:
137+
labels:
129138
"sidecar.istio.io/inject": "true"
139+
annotations:
130140
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
131141
- name: kafka-channel-dispatcher
132-
annotations:
142+
labels:
133143
"sidecar.istio.io/inject": "true"
144+
annotations:
134145
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
135146
- name: kafka-source-dispatcher
136-
annotations:
147+
labels:
137148
"sidecar.istio.io/inject": "true"
149+
annotations:
138150
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
139151
- name: kafka-sink-receiver
140-
annotations:
152+
labels:
141153
"sidecar.istio.io/inject": "true"
154+
annotations:
142155
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
143156
----
144157
<1> The Apache Kafka cluster URL, for example `my-cluster-kafka-bootstrap.kafka:9092`.

modules/serverless-ossm-setup.adoc

Lines changed: 26 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -160,12 +160,14 @@ spec:
160160
enabled: true <1>
161161
deployments: <2>
162162
- name: activator
163-
annotations:
163+
labels:
164164
"sidecar.istio.io/inject": "true"
165+
annotations:
165166
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
166167
- name: autoscaler
167-
annotations:
168+
labels:
168169
"sidecar.istio.io/inject": "true"
170+
annotations:
169171
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
170172
----
171173
<1> Enables Istio integration.
@@ -193,20 +195,24 @@ spec:
193195
istio: enabled <1>
194196
workloads:
195197
- name: pingsource-mt-adapter
196-
annotations:
198+
labels:
197199
"sidecar.istio.io/inject": "true" <2>
200+
annotations:
198201
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
199202
- name: imc-dispatcher
200-
annotations:
203+
labels:
201204
"sidecar.istio.io/inject": "true"
205+
annotations:
202206
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
203207
- name: mt-broker-ingress
204-
annotations:
208+
labels:
205209
"sidecar.istio.io/inject": "true"
210+
annotations:
206211
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
207212
- name: mt-broker-filter
208-
annotations:
213+
labels:
209214
"sidecar.istio.io/inject": "true"
215+
annotations:
210216
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
211217
----
212218
<1> Enables Eventing istio controller to create a `DestinationRule` for each InMemoryChannel or KafkaChannel service.
@@ -247,32 +253,39 @@ spec:
247253
enabled: true
248254
workloads: <2>
249255
- name: kafka-controller
250-
annotations:
256+
labels:
251257
"sidecar.istio.io/inject": "true"
258+
annotations:
252259
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
253260
- name: kafka-broker-receiver
254-
annotations:
261+
labels:
255262
"sidecar.istio.io/inject": "true"
263+
annotations:
256264
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
257265
- name: kafka-broker-dispatcher
258-
annotations:
266+
labels:
259267
"sidecar.istio.io/inject": "true"
268+
annotations:
260269
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
261270
- name: kafka-channel-receiver
262-
annotations:
271+
labels:
263272
"sidecar.istio.io/inject": "true"
273+
annotations:
264274
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
265275
- name: kafka-channel-dispatcher
266-
annotations:
276+
labels:
267277
"sidecar.istio.io/inject": "true"
278+
annotations:
268279
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
269280
- name: kafka-source-dispatcher
270-
annotations:
281+
labels:
271282
"sidecar.istio.io/inject": "true"
283+
annotations:
272284
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
273285
- name: kafka-sink-receiver
274-
annotations:
286+
labels:
275287
"sidecar.istio.io/inject": "true"
288+
annotations:
276289
"sidecar.istio.io/rewriteAppHTTPProbers": "true"
277290
----
278291
<1> The Apache Kafka cluster URL, for example: `my-cluster-kafka-bootstrap.kafka:9092`.

0 commit comments

Comments
 (0)