Merge pull request #93569 from laubai/osdocs-14094-feedback-hcp-prepare-your-environment

OSDOCS-14094 Pre-publish feedback for Prepare your environment

Author: mburke5678

_attributes/attributes-openshift-dedicated.adoc

@@ -56,3 +56,5 @@
 :rosa-classic-first: {product-title} (ROSA) (classic architecture)
 :egress-lockdown: {hcp-title} clusters with zero egress
 //ROSA CLI variables
+:zero-egress: zero egress
+//unclear whether this is going to be zero egress or egress lockdown

_topic_maps/_topic_map_rosa.yml

@@ -265,6 +265,7 @@ Topics:
   File: rosa-hcp-creating-cluster-with-aws-kms-key
 - Name: Creating a private cluster on ROSA with HCP
   File: rosa-hcp-aws-private-creating-cluster
+# Note the following title should use the same term as the {zero-egress} parameter does
 - Name: Creating a ROSA with HCP cluster with egress lockdown
   File: rosa-hcp-egress-lockdown-install
 - Name: Creating ROSA with HCP clusters with external authentication

_topic_maps/_topic_map_rosa_hcp.yml

@@ -194,6 +194,7 @@ Topics:
   File: rosa-hcp-creating-cluster-with-aws-kms-key
 - Name: Creating a private cluster on ROSA with HCP
   File: rosa-hcp-aws-private-creating-cluster
+# Note the following title should use the same term as the {zero-egress} parameter does
 - Name: Creating a ROSA with HCP cluster with egress lockdown
   File: rosa-hcp-egress-lockdown-install
 - Name: Creating ROSA with HCP clusters with external authentication

modules/machine-pools-hcp.adoc

@@ -12,7 +12,7 @@ Each machine pool in an {hcp-title} cluster upgrades independently. Because the
 
 The following image depicts how machine pools work within ROSA and {hcp-title} clusters:
 
-image::hcp-rosa-machine-pools.png[Machine pools on ROSA classic and ROSA with HCP clusters]
+image::hcp-rosa-machine-pools.png[Machine pools on ROSA classic and {hcp-title} clusters]
 
 [NOTE]
 ====

modules/mos-network-prereqs-min-bandwidth.adoc

@@ -7,6 +7,6 @@
 [id="mos-network-prereqs-min-bandwidth_{context}"]
 = Minimum bandwidth
 
-During cluster deployment, {product-title} requires a minimum bandwidth of 120{nbsp}Mbps between cluster resources and public internet resources. When network connectivity is slower than 120{nbsp}Mbps (for example, when connecting through a proxy) the cluster installation process times out and deployment fails.
+During cluster deployment, {product-title} requires a minimum bandwidth of 120{nbsp}Mbps between cluster infrastructure and the public internet or private network locations that provide deployment artifacts and resources. When network connectivity is slower than 120{nbsp}Mbps (for example, when connecting through a proxy) the cluster installation process times out and deployment fails.
 
-After deployment, network requirements are determined by your workload. However, a minimum bandwidth of 120{nbsp}Mbps helps to ensure timely cluster and operator upgrades.
+After cluster deployment, network requirements are determined by your workload. However, a minimum bandwidth of 120{nbsp}Mbps helps to ensure timely cluster and operator upgrades.

modules/rosa-aws-provisioned.adoc

@@ -41,12 +41,9 @@ The instance type shown for worker nodes is the default value, but you can custo
 [id="rosa-ebs-storage_{context}"]
 == Amazon Elastic Block Store storage
 
-Amazon Elastic Block Store (Amazon EBS) block storage is used for both local node storage and persistent volume storage. The following values are the default size of the local, ephemeral storage provisioned for each EC2 instance.
-
-Volume requirements for each EC2 instance:
+Amazon Elastic Block Store (Amazon EBS) block storage is used for both local node storage and persistent volume storage. By default, the following storage is provisioned for each EC2 instance:
 
 ifndef::openshift-rosa-hcp[]
-
 * Control Plane Volume
 ** Size: 350GB
 ** Type: gp3
@@ -57,18 +54,24 @@ ifndef::openshift-rosa-hcp[]
 ** Type: gp3
 ** Input/Output Operations Per Second: 900
 
-endif::openshift-rosa-hcp[]
-
 * Worker Volume
-** Default size: 300GB
-ifndef::openshift-rosa-hcp[]
+** Default size: 300{nbsp}GiB (adjustable at creation time)
 ** Minimum size: 128GB
-endif::openshift-rosa-hcp[]
-ifndef::openshift-rosa-hcp[]
-** Minimum size: 75GB
-endif::openshift-rosa-hcp[]
 ** Type: gp3
 ** Input/Output Operations Per Second: 900
+endif::openshift-rosa-hcp[]
+ifdef::openshift-rosa-hcp[]
+* Node volumes
+** Type: `AWS EBS GP3`
+** Default size: 300{nbsp}GiB (adjustable at creation time)
+** Minimum size: 75{nbsp}GiB
+
+* Workload persistent volumes
+** Default storage class: `gp3-csi`
+** Provisioner: `ebs.csi.aws.com`
+** Dynamic persistent volume provisioning
+endif::openshift-rosa-hcp[]
+
 
 ifndef::openshift-rosa-hcp[]
 [NOTE]
@@ -85,16 +88,16 @@ endif::openshift-rosa-hcp[]
 ifdef::openshift-rosa-hcp[]
 By default, one Network Load Balancer is created for use by the default ingress controller. You can create additional load balancers of the following types according to the needs of your workload:
 
-* Classic Load Balancers
-* Network Load Balancers
-* Application Load Balancers
+* Classic Load Balancer
+* Network Load Balancer
+* Application Load Balancer
 
 endif::openshift-rosa-hcp[]
 For more information, see the link:https://aws.amazon.com/elasticloadbalancing/features/#Details_for_Elastic_Load_Balancing_Products[ELB documentation for AWS].
 
 [id="rosa-s3-storage_{context}"]
 == S3 storage
-The image registry is backed by AWS S3 storage. Resources Pruning of resources is performed regularly to optimize S3 usage and cluster performance.
+The image registry is backed by AWS S3 storage. Resources are pruned regularly to optimize S3 usage and cluster performance.
 
 //TODO OSDOCS-11789: Confirm that this is still valid
 [NOTE]
@@ -107,13 +110,17 @@ Two buckets are required with a typical size of 2TB each.
 
 Configure your VPC according to the following requirements:
 
-* *Subnets*: Two subnets for a cluster with a single availability zone, or six subnets for a cluster with multiple availability zones.
+* *Subnets*: Every cluster requires a minimum of one private subnet for every availability zone. For example, 1 private subnet is required for a single-zone cluster, and 3 private subnets are required for a cluster with 3 availability zones.
++
+If your cluster needs direct access to a network that is external to the cluster, including the public internet, you require at least one public subnet.
 +
 Red{nbsp}Hat strongly recommends using unique subnets for each cluster. Sharing subnets between multiple clusters is not recommended.
 +
 [NOTE]
 ====
-A *public subnet* connects directly to the internet through an internet gateway. A *private subnet* connects to the internet through a network address translation (NAT) gateway.
+A *public subnet* connects directly to the internet through an internet gateway.
+
+A *private subnet* connects to the internet through a network address translation (NAT) gateway.
 ====
 
 * *Route tables*: One route table per private subnet, and one additional table per cluster.
@@ -194,4 +201,4 @@ can add additional custom security groups during cluster creation. Custom securi
 
 * You must create the custom security groups in AWS before you create the cluster. For more information, see link:https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-security-groups.html[Amazon EC2 security groups for Linux instances].
 * You must associate the custom security groups with the VPC that the cluster will be installed into. Your custom security groups cannot be associated with another VPC.
-* You might need to request additional quota for your VPC if you are adding additional custom security groups. For information on AWS quota requirements for ROSA, see _Required AWS service quotas_ in _Prepare your environment_. For information on requesting an AWS quota increase, see link:https://docs.aws.amazon.com/servicequotas/latest/userguide/request-quota-increase.html[Requesting a quota increase].
+* You might need to request additional quota for your VPC if you are adding additional custom security groups. For information on AWS quota requirements for ROSA, see _Required AWS service quotas_ in _Prepare your environment_. For information on requesting an AWS quota increase, see link:https://docs.aws.amazon.com/servicequotas/latest/userguide/request-quota-increase.html[Requesting a quota increase].

modules/rosa-create-objects.adoc

@@ -868,7 +868,7 @@ $ rosa create machinepool --cluster=mycluster --replicas=2 --instance-type=r5.2x
 [id="rosa-create-network_{context}"]
 == create network
 
-Create a network that creates any necessary AWS resources through AWS CloudFormation templates. This helper command is intended to help create and configure a VPC for use with {hcp-title}. This command also supports zero egress clusters.
+Create a network that creates any necessary AWS resources through AWS CloudFormation templates. This helper command is intended to help create and configure a VPC for use with {hcp-title}. This command also supports {zero-egress} clusters.
 
 [IMPORTANT]
 ====