Don't convert strings to numbers in schema validation

Signed-off-by: Daniel Widdis <widdis@gmail.com>

Author: dbwiddis

plugin/src/main/java/org/opensearch/ml/utils/MLNodeUtils.java

@@ -109,10 +109,14 @@ public static String processRemoteInferenceInputDataSetParametersValue(String in
                 if (value.isTextual()) {
                     String textValue = value.asText();
                     try {
-                        // Try to parse the string as JSON
-                        JsonNode parsedValue = mapper.readTree(textValue);
-                        // If successful, replace the string with the parsed JSON
-                        parametersNode.set(key, parsedValue);
+                        // Only try to parse as JSON if it looks like a JSON object or array
+                        if ((textValue.startsWith("{") && textValue.endsWith("}"))
+                            || (textValue.startsWith("[") && textValue.endsWith("]"))) {
+                            // Try to parse the string as JSON
+                            JsonNode parsedValue = mapper.readTree(textValue);
+                            // If successful, replace the string with the parsed JSON
+                            parametersNode.set(key, parsedValue);
+                        }
                     } catch (IOException e) {
                         // If parsing fails, it's not a valid JSON string, so keep it as is
                         parametersNode.set(key, value);

plugin/src/test/java/org/opensearch/ml/utils/MLNodeUtilsTests.java

@@ -161,6 +161,13 @@ public void testProcessRemoteInferenceInputDataSetParametersValueWithParametersP
         assertEquals(expectedJson, processedJson);
     }
 
+    @Test
+    public void testProcessRemoteInferenceInputDataSetParametersValueWithParametersQuotedNumber() throws IOException {
+        String json = "{\"key1\":\"foo\",\"key2\":123,\"key3\":true,\"parameters\":{\"key1\":\"123\",\"key2\":123,\"key3\":true}}";
+        String processedJson = MLNodeUtils.processRemoteInferenceInputDataSetParametersValue(json);
+        assertEquals(json, processedJson);
+    }
+
     @Test
     public void testProcessRemoteInferenceInputDataSetParametersValueWithParametersNoProcess() throws IOException {
         String json = "{\"key1\":\"foo\",\"key2\":123,\"key3\":true,\"parameters\":{\"key1\":\"foo\",\"key2\":123,\"key3\":true}}";