for inline model connector name isn't required (#3882)

* for inline model connector name isn't required

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* adding unit test

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* test was failing

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

---------

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

Author: dhrubo-os

common/src/main/java/org/opensearch/ml/common/transport/connector/MLCreateConnectorRequest.java

@@ -46,7 +46,9 @@ public ActionRequestValidationException validate() {
             return addValidationError("ML Connector input can't be null", null);
         }
         Map<String, FieldDescriptor> fieldsToValidate = new HashMap<>();
-        fieldsToValidate.put("Model connector name", new FieldDescriptor(mlCreateConnectorInput.getName(), true));
+
+        fieldsToValidate
+            .put("Model connector name", new FieldDescriptor(mlCreateConnectorInput.getName(), !mlCreateConnectorInput.isDryRun()));
         fieldsToValidate.put("Model connector description", new FieldDescriptor(mlCreateConnectorInput.getDescription(), false));
 
         return validateFields(fieldsToValidate);

common/src/test/java/org/opensearch/ml/common/transport/connector/MLCreateConnectorRequestTests.java

@@ -6,6 +6,7 @@
 package org.opensearch.ml.common.transport.connector;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertNotSame;
 import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertSame;
@@ -267,4 +268,47 @@ public void validateWithEmptyAndInvalidModelConnectorNameAndDescription() {
         );
     }
 
+    @Test
+    public void validateWithDryRun() {
+        // Test with dry run set to true
+        MLCreateConnectorInput dryRunInput = MLCreateConnectorInput
+            .builder()
+            .name("")  // Empty name, which would normally fail validation
+            .description("Test description")
+            .version("1")
+            .protocol("http")
+            .parameters(Map.of("input", "test"))
+            .credential(Map.of("key", "value"))
+            .actions(List.of())
+            .access(AccessMode.PUBLIC)
+            .backendRoles(Arrays.asList("role1"))
+            .addAllBackendRoles(false)
+            .dryRun(true)  // Set dry run to true
+            .build();
+
+        MLCreateConnectorRequest dryRunRequest = MLCreateConnectorRequest.builder().mlCreateConnectorInput(dryRunInput).build();
+        ActionRequestValidationException dryRunException = dryRunRequest.validate();
+        assertNull("Validation should pass when dry run is true, even with empty name", dryRunException);
+
+        // Test with dry run set to false (default behavior)
+        MLCreateConnectorInput nonDryRunInput = MLCreateConnectorInput
+            .builder()
+            .name("")  // Empty name, which should fail validation
+            .description("Test description")
+            .version("1")
+            .protocol("http")
+            .parameters(Map.of("input", "test"))
+            .credential(Map.of("key", "value"))
+            .actions(List.of())
+            .access(AccessMode.PUBLIC)
+            .backendRoles(Arrays.asList("role1"))
+            .addAllBackendRoles(false)
+            .dryRun(false)  // Set dry run to false
+            .build();
+
+        MLCreateConnectorRequest nonDryRunRequest = MLCreateConnectorRequest.builder().mlCreateConnectorInput(nonDryRunInput).build();
+        ActionRequestValidationException nonDryRunException = nonDryRunRequest.validate();
+        assertNotNull("Validation should fail when dry run is false and name is empty", nonDryRunException);
+        assertTrue(nonDryRunException.getMessage().contains("Model connector name is required"));
+    }
 }

ml-algorithms/src/test/java/org/opensearch/ml/engine/algorithms/text_embedding/ModelHelperTest.java

@@ -207,7 +207,7 @@ public void testDownloadPrebuiltModelMetaList() throws PrivilegedActionException
         MLRegisterModelInput registerModelInput = MLRegisterModelInput
             .builder()
             .modelName("huggingface/sentence-transformers/all-mpnet-base-v2")
-            .version("1.0.1")
+            .version("1.0.2")
             .modelGroupId("mockGroupId")
             .modelFormat(modelFormat)
             .deployModel(false)
@@ -223,7 +223,7 @@ public void testIsModelAllowed_true() throws PrivilegedActionException {
         MLRegisterModelInput registerModelInput = MLRegisterModelInput
             .builder()
             .modelName("huggingface/sentence-transformers/all-mpnet-base-v2")
-            .version("1.0.1")
+            .version("1.0.2")
             .modelGroupId("mockGroupId")
             .modelFormat(modelFormat)
             .deployModel(false)