Merge pull request #383 from openscript-ch/322-select-multiple-days-with-the-same-pattern

322 select multiple days with the same pattern

Author: openscript

.changeset/strong-bottles-tease.md

@@ -0,0 +1,6 @@
+---
+"@quassel/frontend": minor
+"@quassel/backend": minor
+---
+
+Allow creating entries for multiple days

apps/backend/src/research/entries/entries.controller.ts

@@ -2,7 +2,7 @@ import { Body, Controller, Delete, Get, Param, Patch, Post, Query } from "@nestj
 import { ApiTags, ApiOperation, ApiUnprocessableEntityResponse, ApiQuery } from "@nestjs/swagger";
 import { ErrorResponseDto } from "../../common/dto/error.dto";
 import { EntriesService } from "./entries.service";
-import { EntryCreationDto, EntryResponseDto, EntryMutationDto } from "./entry.dto";
+import { EntryCreationDto, EntryResponseDto, EntryUpdateDto } from "./entry.dto";
 import { Serialize } from "../../common/decorators/serialize";
 
 @ApiTags("Entries")
@@ -13,8 +13,7 @@ export class EntriesController {
   @Post()
   @ApiOperation({ summary: "Create a entry" })
   @ApiUnprocessableEntityResponse({ description: "Unique name constraint violation", type: ErrorResponseDto })
-  @Serialize(EntryResponseDto)
-  create(@Body() entry: EntryCreationDto): Promise<EntryResponseDto> {
+  create(@Body() entry: EntryCreationDto): Promise<number[]> {
     return this.entriesService.create(entry);
   }
 
@@ -35,7 +34,7 @@ export class EntriesController {
   @Patch(":id")
   @ApiOperation({ summary: "Update a entry by ID" })
   @Serialize(EntryResponseDto)
-  update(@Param("id") id: string, @Body() entry: EntryMutationDto): Promise<EntryResponseDto> {
+  update(@Param("id") id: string, @Body() entry: EntryUpdateDto): Promise<EntryResponseDto> {
     return this.entriesService.update(+id, entry);
   }
 

apps/backend/src/research/entries/entries.service.ts

@@ -1,7 +1,7 @@
-import { EntityRepository, UniqueConstraintViolationException, FilterQuery } from "@mikro-orm/core";
+import { EntityRepository, FilterQuery } from "@mikro-orm/core";
 import { InjectRepository } from "@mikro-orm/nestjs";
-import { Injectable, UnprocessableEntityException } from "@nestjs/common";
-import { EntryCreationDto, EntryMutationDto } from "./entry.dto";
+import { Injectable } from "@nestjs/common";
+import { EntryCreationDto, EntryUpdateDto } from "./entry.dto";
 import { Entry } from "./entry.entity";
 import { EntityManager, raw } from "@mikro-orm/postgresql";
 
@@ -13,20 +13,15 @@ export class EntriesService {
     private readonly em: EntityManager
   ) {}
 
-  async create(entryCreationDto: EntryCreationDto) {
-    const entry = new Entry();
-    entry.assign(entryCreationDto, { em: this.em });
+  create({ weekday, ...rest }: EntryCreationDto) {
+    return this.entryRepository.insertMany(
+      weekday.map((w) => {
+        const entry = new Entry();
+        entry.assign({ weekday: w, ...rest }, { em: this.em });
 
-    try {
-      await this.em.persist(entry).flush();
-    } catch (e) {
-      if (e instanceof UniqueConstraintViolationException) {
-        throw new UnprocessableEntityException("Entry with this name already exists");
-      }
-      throw e;
-    }
-
-    return (await entry.populate(["entryLanguages"])).toObject();
+        return entry;
+      })
+    );
   }
 
   async findAll() {
@@ -66,7 +61,7 @@ export class EntriesService {
     });
   }
 
-  async update(id: number, entryMutationDto: EntryMutationDto) {
+  async update(id: number, entryMutationDto: EntryUpdateDto) {
     const entry = await this.entryRepository.findOneOrFail(id, { populate: ["entryLanguages"] });
 
     entry.assign(entryMutationDto);

apps/backend/src/research/entries/entry.dto.ts

@@ -15,12 +15,6 @@ class EntryBaseDto {
   @Expose()
   endedAt: string;
 
-  @ApiProperty({ example: 1, description: "The weekday of the entry (Sunday is 0 like in JS)" })
-  @Min(0)
-  @Max(6)
-  @Expose()
-  weekday: number;
-
   @ApiProperty({ example: 1, description: "The weekly recurring of the entry" })
   @Min(1)
   @IsOptional()
@@ -32,6 +26,12 @@ export class EntryResponseDto extends EntryBaseDto {
   @Expose()
   id: number;
 
+  @ApiProperty({ example: 1, description: "The weekday of the entry (Sunday is 0 like in JS)" })
+  @Min(0)
+  @Max(6)
+  @Expose()
+  weekday: number;
+
   @Type(() => CarerResponseDto)
   @Expose()
   carer: CarerResponseDto;
@@ -41,14 +41,17 @@ export class EntryResponseDto extends EntryBaseDto {
   entryLanguages: Array<EntryLanguageResponseDto>;
 }
 
-export class EntryCreationDto extends EntryBaseDto {
+class EntryMutationDto extends EntryBaseDto {
   carer: number;
   questionnaire: number;
 
   @Type(() => EntryLanguageCreationDto)
   entryLanguages: Array<EntryLanguageCreationDto>;
 }
-export class EntryMutationDto extends PartialType(EntryCreationDto) {}
+export class EntryCreationDto extends EntryMutationDto {
+  weekday: number[];
+}
+export class EntryUpdateDto extends PartialType(EntryMutationDto) {}
 
 export class EntryTemplateDto {
   @Type(() => CarerResponseDto)

apps/frontend/src/api.gen.ts

@@ -741,16 +741,12 @@ export interface components {
              * @example 2024-11-01T08:00:00.00Z
              */
             endedAt: string;
-            /**
-             * @description The weekday of the entry (Sunday is 0 like in JS)
-             * @example 1
-             */
-            weekday: number;
             /**
              * @description The weekly recurring of the entry
              * @example 1
              */
             weeklyRecurring?: number;
+            weekday: number[];
             carer: number;
             questionnaire: number;
             entryLanguages: components["schemas"]["EntryLanguageCreationDto"][];
@@ -766,11 +762,6 @@ export interface components {
              * @example 2024-11-01T08:00:00.00Z
              */
             endedAt: string;
-            /**
-             * @description The weekday of the entry (Sunday is 0 like in JS)
-             * @example 1
-             */
-            weekday: number;
             /**
              * @description The weekly recurring of the entry
              * @example 1
@@ -781,10 +772,15 @@ export interface components {
              * @example 1
              */
             id: number;
+            /**
+             * @description The weekday of the entry (Sunday is 0 like in JS)
+             * @example 1
+             */
+            weekday: number;
             carer: components["schemas"]["CarerResponseDto"];
             entryLanguages: components["schemas"]["EntryLanguageResponseDto"][];
         };
-        EntryMutationDto: {
+        EntryUpdateDto: {
             /**
              * @description The starting date of the entry
              * @example 2024-11-01T07:00:00.000Z
@@ -795,11 +791,6 @@ export interface components {
              * @example 2024-11-01T08:00:00.00Z
              */
             endedAt?: string;
-            /**
-             * @description The weekday of the entry (Sunday is 0 like in JS)
-             * @example 1
-             */
-            weekday?: number;
             /**
              * @description The weekly recurring of the entry
              * @example 1
@@ -1829,7 +1820,7 @@ export interface operations {
                     [name: string]: unknown;
                 };
                 content: {
-                    "application/json": components["schemas"]["EntryResponseDto"];
+                    "application/json": number[];
                 };
             };
             /** @description Unique name constraint violation */
@@ -1915,7 +1906,7 @@ export interface operations {
         };
         requestBody: {
             content: {
-                "application/json": components["schemas"]["EntryMutationDto"];
+                "application/json": components["schemas"]["EntryUpdateDto"];
             };
         };
         responses: {

apps/frontend/src/components/WeekdayPicker.tsx

@@ -1,38 +1,53 @@
-import { SegmentedControl } from "@quassel/ui";
+import { Chip, Group, Select } from "@quassel/ui";
 import { i18n } from "../stores/i18n";
 import { useStore } from "@nanostores/react";
 
-type WeekdayPickerProps = {
-  value?: number;
-  onChange?: (weekday: number) => void;
-};
+type WeekdayPickerProps =
+  | { value?: number; onChange?: (weekday?: number) => void; multiple?: false }
+  | { value?: number[]; onChange?: (weekday: number[]) => void; multiple: true };
 
 const messages = i18n("WeekdayPicker", {
-  mondayLabel: "Mo",
-  tusedayLabel: "Tu",
-  wednesdayLabel: "We",
-  thrusdayLabel: "Th",
-  fridayLabel: "Fr",
-  saturdayLabel: "Sa",
-  sundayLabel: "Su",
+  mondayShortLabel: "Mo",
+  mondayLabel: "Monday",
+  tusedayShortLabel: "Tu",
+  tusedayLabel: "Tuesday",
+  wednesdayShortLabel: "We",
+  wednesdayLabel: "Wednesday",
+  thursdayShortLabel: "Th",
+  thursdayLabel: "Thursday",
+  fridayShortLabel: "Fr",
+  fridayLabel: "Friday",
+  saturdayShortLabel: "Sa",
+  saturdayLabel: "Saturday",
+  sundayShortLabel: "Su",
+  sundayLabel: "Sunday",
 });
 
-export function WeekdayPicker({ onChange, value }: WeekdayPickerProps) {
+export function WeekdayPicker({ onChange, value, multiple }: WeekdayPickerProps) {
   const t = useStore(messages);
 
-  return (
-    <SegmentedControl
-      value={value?.toString()}
-      onChange={(value) => onChange?.(parseInt(value))}
-      data={[
-        { value: "1", label: t.mondayLabel },
-        { value: "2", label: t.tusedayLabel },
-        { value: "3", label: t.wednesdayLabel },
-        { value: "4", label: t.thrusdayLabel },
-        { value: "5", label: t.fridayLabel },
-        { value: "6", label: t.saturdayLabel },
-        { value: "0", label: t.sundayLabel },
-      ]}
-    />
-  );
+  const weekdayOptions = [
+    { value: "1", label: t.mondayLabel, short: t.mondayShortLabel },
+    { value: "2", label: t.tusedayLabel, short: t.tusedayShortLabel },
+    { value: "3", label: t.wednesdayLabel, short: t.wednesdayShortLabel },
+    { value: "4", label: t.thursdayLabel, short: t.thursdayShortLabel },
+    { value: "5", label: t.fridayLabel, short: t.fridayShortLabel },
+    { value: "6", label: t.saturdayLabel, short: t.saturdayShortLabel },
+    { value: "0", label: t.sundayLabel, short: t.sundayShortLabel },
+  ];
+
+  if (multiple)
+    return (
+      <Chip.Group multiple value={value?.map(String)} onChange={(values) => onChange?.(values.map(Number))}>
+        <Group gap={"xs"}>
+          {weekdayOptions.map(({ value, short }) => (
+            <Chip key={value} value={value}>
+              {short}
+            </Chip>
+          ))}
+        </Group>
+      </Chip.Group>
+    );
+
+  return <Select data={weekdayOptions} value={value?.toString()} onChange={(v) => onChange?.(v ? parseInt(v) : undefined)} />;
 }

apps/frontend/src/components/questionnaire/QuestionnaireEntries.tsx

@@ -62,7 +62,7 @@ export function QuestionnaireEntries({ questionnaire, gaps }: QuestionnaireEntri
   const handleCreate = (entry: EntryFormValues) => {
     const entryRequest = { ...entry, questionnaire: questionnaire.id };
 
-    return createMutation.mutateAsync({ body: entryRequest }, { onSuccess: reloadEntries });
+    return createMutation.mutateAsync({ body: entryRequest as components["schemas"]["EntryCreationDto"] }, { onSuccess: reloadEntries });
   };
 
   const handleUpdate = (id: number, entry: Partial<EntryFormValues>) => {