Skip to content

Commit a057087

Browse files
authored
Merge pull request #8 from openscd/fix/save-button-disabled-state
fix: reset save button disabled state after saving
2 parents e9703b2 + 07161af commit a057087

17 files changed

+8
-11
lines changed

.github/workflows/test-on-pr-branch.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ on: pull_request
33

44
jobs:
55
unit:
6-
runs-on: ubuntu-20.04
6+
runs-on: ubuntu-22.04
77
steps:
88
- name: Checkout
99
uses: actions/checkout@v3
@@ -22,7 +22,7 @@ jobs:
2222
- name: Run unit tests
2323
run: npm run-script test:unit
2424
visual:
25-
runs-on: ubuntu-20.04
25+
runs-on: ubuntu-22.04
2626
steps:
2727
- name: Checkout
2828
uses: actions/checkout@v3
@@ -52,4 +52,4 @@ jobs:
5252
name: failed_screenshots
5353
path: |
5454
screenshots/*/failed/
55-
screenshots/*/baseline/
55+
screenshots/*/baseline/

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ on: [push, workflow_dispatch]
33

44
jobs:
55
test:
6-
runs-on: ubuntu-20.04
6+
runs-on: ubuntu-22.04
77
steps:
88
- name: Checkout
99
uses: actions/checkout@v3

.github/workflows/update-screenshots.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ on: workflow_dispatch
44

55
jobs:
66
test:
7-
runs-on: ubuntu-20.04
7+
runs-on: ubuntu-22.04
88
steps:
99
- name: Checkout
1010
uses: actions/checkout@v3
@@ -28,7 +28,7 @@ jobs:
2828
run: npm run test:update
2929

3030
- name: Upload failed screenshots as artifacts
31-
uses: actions/upload-artifact@v3
31+
uses: actions/upload-artifact@v4
3232
if: failure()
3333
with:
3434
name: failed_screenshots

editors/sampledvalue/sampled-value-control-element-editor.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -170,8 +170,6 @@ export class SampledValueControlElementEditor extends ScopedElementsMixin(
170170
);
171171

172172
this.resetInputs();
173-
174-
this.onSampledValueControlInputChange();
175173
}
176174

177175
private onSMVInputChange(): void {
@@ -472,11 +470,10 @@ export class SampledValueControlElementEditor extends ScopedElementsMixin(
472470
><md-text-button
473471
class="smvcontrol save"
474472
label="save"
475-
icon="save"
476473
?disabled=${!this.sampledValueControlDiff}
477474
@click="${this.saveSampledValueControlChanges}"
478-
>Save<md-icon slot="save"></md-icon
479-
></md-text-button>
475+
>Save<md-icon slot="icon">save</md-icon></md-text-button
476+
>
480477
</div>`;
481478
}
482479

285 Bytes
Loading
Loading
314 Bytes
Loading
304 Bytes
Loading
290 Bytes
Loading
293 Bytes
Loading

0 commit comments

Comments
 (0)