Enable lint check in actions

Author: akclace

.github/workflows/golangci-lint.yml

@@ -0,0 +1,25 @@
+name: golangci-lint
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+
+permissions:
+  contents: read
+  # Optional: allow read access to pull requests. Use with `only-new-issues` option.
+  # pull-requests: read
+
+jobs:
+  golangci:
+    name: lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v5
+      - uses: actions/setup-go@v6
+        with:
+          go-version: stable
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v8
+        with:
+          version: v2.1

Makefile

@@ -17,12 +17,13 @@ endif
 .RECIPEPREFIX = >
 TAG := 
 
-.PHONY: help test unit int release int_single
+.PHONY: help test unit int release int_single lint verify
 
 help: ## Display this help section
 > @awk 'BEGIN {FS = ":.*?## "} /^[a-zA-Z0-9_-]+:.*?## / {printf "\033[36m%-38s\033[0m %s\n", $$1, $$2}' $(MAKEFILE_LIST)
 
 test: unit int ## Run all tests
+verify: lint test ## Run lint and all tests
 
 covtest: covunit covint ## Run all tests with coverage
 > go tool covdata percent -i=$(OPENRUN_HOME)/coverage/client,$(OPENRUN_HOME)/coverage/unit,$(OPENRUN_HOME)/coverage/int
@@ -32,6 +33,9 @@ covtest: covunit covint ## Run all tests with coverage
 unit: ## Run unit tests
 > go test ./...
 
+lint: ## Run lint
+> golangci-lint run
+
 covunit: ## Run unit tests with coverage
 > rm -rf $(OPENRUN_HOME)/coverage/unit && mkdir -p $(OPENRUN_HOME)/coverage/unit
 > go test -coverpkg ./... ./... -args -test.gocoverdir="$(OPENRUN_HOME)/coverage/unit"

tests/test_basics.yaml

@@ -26,8 +26,7 @@ tests:
 
   basic040:
     command: CL_CONFIG_FILE=config_basic_client_https.toml ../openrun app list /invalid # Test TLS
-    stderr: "error: 404 page not found"
-    exit-code: 1
+    exit-code: 1 # error can be 404 (if mkcert is installed) or cert check failure (if no mkcert)
 
   basic050:
     command: CL_CONFIG_FILE=config_basic_client_https_skip.toml ../openrun app list /invalid # TLS with skip_cert_check