refactor: Inline local variable assignments before return/throw

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.InlineVariable?organizationId=ODQ2MGExMTUtNDg0My00N2EwLTgzMGMtNGE1NGExMTBmZDkw

Co-authored-by: Moderne <team@moderne.io>

Author: 2 people

src/main/java/org/openrewrite/java/logging/slf4j/ChangeLogLevel.java

@@ -91,10 +91,9 @@ public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, Execu
                 if (!StringUtils.isBlank(startsWith) && !lit.getValue().toString().startsWith(startsWith)) {
                     return m;
                 }
-                m = (J.MethodInvocation) new ChangeMethodName(methodPattern, to.name().toLowerCase(), true, null)
+                return (J.MethodInvocation) new ChangeMethodName(methodPattern, to.name().toLowerCase(), true, null)
                         .getVisitor()
                         .visitNonNull(m, ctx);
-                return m;
             }
         });
     }

src/main/java/org/openrewrite/java/logging/slf4j/Slf4jLogShouldBeConstant.java

@@ -100,16 +100,14 @@ public J visitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx)
                             if (TypeUtils.isAssignableTo(JavaType.ShallowClass.build("java.lang.Throwable"), valueOf.getType())) {
                                 J.MethodInvocation m = JavaTemplate.builder("\"Exception\", #{any()}").contextSensitive().build()
                                         .apply(getCursor(), method.getCoordinates().replaceArguments(), valueOf);
-                                m = m.withSelect(method.getSelect());
-                                return m;
+                                return m.withSelect(method.getSelect());
                             }
                         } else if (OBJECT_TO_STRING.matches(args.get(0))) {
                             Expression toString = ((J.MethodInvocation) args.get(0)).getSelect();
                             if (toString != null) {
                                 J.MethodInvocation m = JavaTemplate.builder("\"{}\", #{any()}").contextSensitive().build()
                                         .apply(getCursor(), method.getCoordinates().replaceArguments(), toString);
-                                m = m.withSelect(method.getSelect());
-                                return m;
+                                return m.withSelect(method.getSelect());
                             }
                         }
                     }