Skip to content

Typo in schema.csv: "addresss" should be "address" #559

@For-The-Greater-Good

Description

@For-The-Greater-Good

Hello! We're working on a project that includes HSDS as a submodule and are ingesting the CSV files programmatically. During our development, we noticed what appears to be a typo.

Description

In the file /schema/simple/schema.csv at line 95, the field name is written as "addresss" (with three s's) when it should be "address" (with two s's).

Location

The typo can be found here:

location,addresss,array,,,false,false,,address.json,,

Supporting Information

According to the HSDS changelog, the correct table name is "address" (singular):

  • The changelog mentions that "physical_address and postal_address combined and renamed to address"
  • The documentation consistently refers to this as "address" throughout

Additional Investigation

We ran grep -rn "addresss" . to search for other occurrences in the codebase but didn't find any other instances. However, we're not sure if this CSV file is autogenerated from your build tools or hand-created. If it's autogenerated, the typo might exist in the source code or generation scripts that we couldn't locate.

Impact

Since we're programmatically parsing these CSV files, this typo could potentially cause issues for automated implementations and lead to inconsistencies. Other projects consuming this schema programmatically may encounter similar issues.

Suggested Fix

Change "addresss" to "address" in the schema.csv file. If this file is autogenerated, the fix would need to be applied to the source/generation code instead.

I'd be happy to submit a pull request to fix this if that would be helpful. Please let me know if you need any additional information.

Thank you for maintaining this important specification!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions