cpplint

Author: zjwhitehead

inc/sp140/alert_display.h

@@ -20,7 +20,7 @@ struct AlertCounts {
 struct AlertEvent {
   SensorID sensorId;
   AlertLevel level;   // New level (OK, WARN_*, CRIT_*)
-  uint32_t timestamp; // When event was generated (millis)
+  uint32_t timestamp;  // When event was generated (millis)
 };
 
 // Global queues

inc/sp140/lvgl/lvgl_alerts.h

@@ -1,5 +1,5 @@
-#ifndef LVGL_ALERTS_H
-#define LVGL_ALERTS_H
+#ifndef INC_SP140_LVGL_LVGL_ALERTS_H_
+#define INC_SP140_LVGL_LVGL_ALERTS_H_
 
 #include <lvgl.h>
 #include "../simple_monitor.h"
@@ -30,4 +30,4 @@ void lv_showAlertText(SensorID id, bool critical);
 void lv_showAlertTextWithLevel(SensorID id, AlertLevel level, bool critical);
 void lv_hideAlertText();
 
-#endif // LVGL_ALERTS_H
+#endif  // INC_SP140_LVGL_LVGL_ALERTS_H_

inc/sp140/lvgl/lvgl_core.h

@@ -1,5 +1,5 @@
-#ifndef LVGL_CORE_H
-#define LVGL_CORE_H
+#ifndef INC_SP140_LVGL_LVGL_CORE_H_
+#define INC_SP140_LVGL_LVGL_CORE_H_
 
 #include <lvgl.h>
 #include <Adafruit_ST7735.h>
@@ -38,4 +38,4 @@ void lv_tick_handler();
 void updateLvgl();
 void displayLvglSplash(const STR_DEVICE_DATA_140_V1& deviceData, int duration);
 
-#endif // LVGL_CORE_H
+#endif  // INC_SP140_LVGL_LVGL_CORE_H_

inc/sp140/lvgl/lvgl_main_screen.h

@@ -1,5 +1,5 @@
-#ifndef LVGL_MAIN_SCREEN_H
-#define LVGL_MAIN_SCREEN_H
+#ifndef INC_SP140_LVGL_LVGL_MAIN_SCREEN_H_
+#define INC_SP140_LVGL_LVGL_MAIN_SCREEN_H_
 
 #include <lvgl.h>
 #include "lvgl_core.h"
@@ -74,4 +74,4 @@ lv_obj_t* createTempBackground(lv_obj_t* parent, int x, int y, int width, int he
 // Main screen setup function
 void setupMainScreen(bool darkMode);
 
-#endif // LVGL_MAIN_SCREEN_H
+#endif  // INC_SP140_LVGL_LVGL_MAIN_SCREEN_H_

inc/sp140/lvgl/lvgl_updates.h

@@ -1,5 +1,5 @@
-#ifndef LVGL_UPDATES_H
-#define LVGL_UPDATES_H
+#ifndef INC_SP140_LVGL_LVGL_UPDATES_H_
+#define INC_SP140_LVGL_LVGL_UPDATES_H_
 
 #include <lvgl.h>
 #include <freertos/FreeRTOS.h>
@@ -73,4 +73,4 @@ bool isCriticalBorderFlashing();
 void startCriticalBorderFlashDirect();
 void stopCriticalBorderFlashDirect();
 
-#endif // LVGL_UPDATES_H
+#endif  // INC_SP140_LVGL_LVGL_UPDATES_H_

inc/sp140/simple_monitor.h

@@ -100,12 +100,18 @@ struct SerialLogger : ILogger {
 // Multi-sink logger – forwards events to every registered ILogger sink
 struct MultiLogger : ILogger {
   std::vector<ILogger*> sinks;
-  void addSink(ILogger* s) { if (s) sinks.push_back(s); }
+  void addSink(ILogger* s) {
+    if (s) sinks.push_back(s);
+  }
   void log(SensorID id, AlertLevel lvl, float v) override {
-    for (auto* s : sinks) { s->log(id, lvl, v); }
+    for (auto* s : sinks) {
+      s->log(id, lvl, v);
+    }
   }
   void log(SensorID id, AlertLevel lvl, bool v) override {
-    for (auto* s : sinks) { s->log(id, lvl, v); }
+    for (auto* s : sinks) {
+      s->log(id, lvl, v);
+    }
   }
 };
 

src/sp140/alert_display.cpp

@@ -35,7 +35,7 @@ void initAlertDisplay() {
   // Create queues – small, non-blocking
   alertEventQueue  = xQueueCreate(20, sizeof(AlertEvent));
   alertCarouselQueue = xQueueCreate(1, sizeof(AlertSnapshot));
-  alertUIQueue = xQueueCreate(1, sizeof(AlertUIUpdate)); // Unified queue for synchronized updates
+  alertUIQueue = xQueueCreate(1, sizeof(AlertUIUpdate));  // Unified queue for synchronized updates
 
   if (!alertEventQueue || !alertCarouselQueue || !alertUIQueue) {
     USBSerial.println("[AlertDisplay] Failed creating queues");
@@ -53,7 +53,7 @@ void initAlertDisplay() {
 void sendAlertEvent(SensorID id, AlertLevel level) {
   if (!alertEventQueue) return;
   AlertEvent ev{ id, level, millis() };
-  xQueueSend(alertEventQueue, &ev, 0); // best-effort, drop if full
+  xQueueSend(alertEventQueue, &ev, 0);  // best-effort, drop if full
 }
 
 // ------------ Internal implementation -------------
@@ -92,8 +92,7 @@ static void alertAggregationTask(void* parameter) {
           xQueueOverwrite(alertUIQueue, &update);
         }
       }
-    }
-    else {
+    } else {
       // If list empty ensure label hidden once
       static bool hideSent = false;
       if (!hideSent) {
@@ -110,7 +109,7 @@ static void alertAggregationTask(void* parameter) {
 }
 
 static void recalcCountsAndPublish() {
-  AlertCounts counts{0,0};
+  AlertCounts counts{0, 0};
   std::vector<SensorID> critList;
   std::vector<SensorID> warnList;
   for (const auto& kv : g_currentLevels) {

src/sp140/bms.cpp

@@ -29,7 +29,7 @@ void updateBMSData() {
     if (xSemaphoreTake(spiBusMutex, pdMS_TO_TICKS(150)) != pdTRUE) {
       // SPI bus timeout - display might be doing long operation
       USBSerial.println("[BMS] SPI bus timeout - skipping BMS update cycle");
-      return; // Use stale BMS data this cycle rather than hang
+      return;  // Use stale BMS data this cycle rather than hang
     }
   }
   digitalWrite(bmsCS, LOW);
@@ -80,7 +80,7 @@ void updateBMSData() {
 
   bmsTelemetryData.lastUpdateMs = millis();
   unsigned long dur = bmsTelemetryData.lastUpdateMs - tStart;
-  if (dur > 80) { // warn if BMS update is taking longer than a frame
+  if (dur > 80) {  // warn if BMS update is taking longer than a frame
     USBSerial.print("Warn: BMS update slow ");
     USBSerial.print(dur);
     USBSerial.println("ms");

src/sp140/lvgl/lvgl_alerts.cpp

@@ -24,7 +24,7 @@ void loadAlertSnapshot(const AlertSnapshot& snap) {
   }
   const char* txt = sensorIDToAbbreviation(static_cast<SensorID>(snap.ids[0]));
   lv_label_set_text(alert_text_label, txt);
-  lv_obj_set_style_text_color(alert_text_label, snap.criticalMode ? lv_color_make(255,0,0) : lv_color_make(255,165,0), 0);
+  lv_obj_set_style_text_color(alert_text_label, snap.criticalMode ? lv_color_make(255, 0, 0) : lv_color_make(255, 165, 0), 0);
   lv_obj_clear_flag(alert_text_label, LV_OBJ_FLAG_HIDDEN);
 }
 
@@ -105,7 +105,7 @@ void updateAlertCounterDisplay(const AlertCounts& counts) {
   if (counts.warningCount > 0) {
     char buf[4];
     if (counts.warningCount > 9) {
-      strcpy(buf, "9+");
+      snprintf(buf, sizeof(buf), "9+");
     } else {
       snprintf(buf, sizeof(buf), "%u", counts.warningCount);
     }
@@ -119,7 +119,7 @@ void updateAlertCounterDisplay(const AlertCounts& counts) {
   if (counts.criticalCount > 0) {
     char buf[4];
     if (counts.criticalCount > 9) {
-      strcpy(buf, "9+");
+      snprintf(buf, sizeof(buf), "9+");
     } else {
       snprintf(buf, sizeof(buf), "%u", counts.criticalCount);
     }
@@ -173,10 +173,10 @@ void lv_showAlertTextWithLevel(SensorID id, AlertLevel level, bool critical) {
     // Make warning text darker and slightly larger for readability
     lv_obj_set_style_text_font(alert_text_label, &lv_font_montserrat_16, 0);
     // Dark orange for better readability over light background
-    lv_obj_set_style_text_color(alert_text_label, lv_color_make(200,100,0), 0);
+    lv_obj_set_style_text_color(alert_text_label, lv_color_make(200, 100, 0), 0);
   }
   if (critical) {
-    lv_obj_set_style_text_color(alert_text_label, lv_color_make(255,0,0), 0);
+    lv_obj_set_style_text_color(alert_text_label, lv_color_make(255, 0, 0), 0);
   }
   lv_obj_clear_flag(alert_text_label, LV_OBJ_FLAG_HIDDEN);
 }

src/sp140/lvgl/lvgl_core.cpp

@@ -92,7 +92,7 @@ void lvgl_flush_cb(lv_disp_drv_t* disp, const lv_area_t* area, lv_color_t* color
     if (xSemaphoreTake(spiBusMutex, pdMS_TO_TICKS(200)) != pdTRUE) {
       // SPI bus timeout - BMS might be doing long operation, skip display flush
       USBSerial.println("[DISPLAY] SPI bus timeout - skipping display flush");
-      return; // Skip this display update rather than hang
+      return;  // Skip this display update rather than hang
     }
   }
   tft_driver->startWrite();