Avoid double Release() in FindCaptureDevice().

markmaker · markmaker · commit 3bec8e354f7f · 2023-04-12T14:52:37.000+02:00
This fixes a semantic conflict from merging 5e8b963 using ScopedComPtr<> and 58d4be4 using explicit Release().
diff --git a/win/platformcontext.cpp b/win/platformcontext.cpp
@@ -453,7 +453,6 @@ HRESULT FindCaptureDevice(IBaseFilter** ppSrcFilter, const wchar_t* devicePath)
             (FAILED(hr) && strDevicePath == std::to_wstring(num_devices))) {
             VariantClear(&varName);
             hr = pMoniker->BindToObject(0, 0, IID_PPV_ARGS(ppSrcFilter));
-            pMoniker->Release();
             return hr;
         }
         VariantClear(&varName);

Original file line number	Diff line number	Diff line change
`@@ -453,7 +453,6 @@ HRESULT FindCaptureDevice(IBaseFilter** ppSrcFilter, const wchar_t* devicePath)`
`453`	`453`	`(FAILED(hr) && strDevicePath == std::to_wstring(num_devices))) {`
`454`	`454`	`VariantClear(&varName);`
`455`	`455`	`hr = pMoniker->BindToObject(0, 0, IID_PPV_ARGS(ppSrcFilter));`
`456`		`- pMoniker->Release();`
`457`	`456`	`return hr;`
`458`	`457`	`}`
`459`	`458`	`VariantClear(&varName);`