-
Notifications
You must be signed in to change notification settings - Fork 552
Description
Description
We have a Plot
class for plotting geometry here
It currently serves as an interface for both the slice plots and voxel plots.
The defaults and attributes for these plots are a bit different
width can be a sequence of 3 floats (for voxel) or 2 floats (for slices)
voxel plots don't need the basis attribute while slice plots do
i think meshlines does not apply to voxel plots
Perhaps we can change this to two classes called SlicePlot
and VoxelPlot
. There are classes for other types of plots in the plots.py file RayTracePlot, WireframeRayTracePlot SolidRayTracePlot
so perhpas also good to split these two out?
Alternatives
longer term we have a region.plot, cell.plot, gementry.plot and universe.plot. We could consider adding .voxel_plot as a method on these shapes.
Compatibility
The would be an API change so a deprecated warning would be needed.